From mboxrd@z Thu Jan 1 00:00:00 1970 From: WANG Cong Subject: Re: [PATCH] netconsole: fix build when CONFIG_NETCONSOLE_DYNAMIC is turned on Date: Tue, 21 Jun 2011 12:50:14 +0000 (UTC) Message-ID: References: <20110620122835.444f16d7.akpm@linux-foundation.org> <20110620212504.e639ad5c.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To: netdev@vger.kernel.org Return-path: Received: from lo.gmane.org ([80.91.229.12]:56890 "EHLO lo.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827Ab1FUMud (ORCPT ); Tue, 21 Jun 2011 08:50:33 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QZ0PT-0005mX-8O for netdev@vger.kernel.org; Tue, 21 Jun 2011 14:50:32 +0200 Received: from 202.106.149.182 ([202.106.149.182]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Jun 2011 14:50:27 +0200 Received: from xiyou.wangcong by 202.106.149.182 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Jun 2011 14:50:27 +0200 Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 20 Jun 2011 21:25:04 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > When NETCONSOLE_DYNAMIC=y and CONFIGFS_FS=m, there are build errors in > netconsole: > > drivers/built-in.o: In function `drop_netconsole_target': > netconsole.c:(.text+0x1a100f): undefined reference to `config_item_put' > drivers/built-in.o: In function `make_netconsole_target': > netconsole.c:(.text+0x1a10b9): undefined reference to > `config_item_init_type_name' drivers/built-in.o: In function > `write_msg': netconsole.c:(.text+0x1a11a4): undefined reference to > `config_item_get' netconsole.c:(.text+0x1a1211): undefined reference to > `config_item_put' drivers/built-in.o: In function > `netconsole_netdev_event': netconsole.c:(.text+0x1a12cc): undefined > reference to `config_item_put' netconsole.c:(.text+0x1a12ec): undefined > reference to `config_item_get' netconsole.c:(.text+0x1a1366): undefined > reference to `config_item_put' drivers/built-in.o: In function > `init_netconsole': netconsole.c:(.init.text+0x953a): undefined reference > to `config_group_init' netconsole.c:(.init.text+0x9560): undefined > reference to `configfs_register_subsystem' drivers/built-in.o: In > function `dynamic_netconsole_exit': netconsole.c:(.exit.text+0x809): > undefined reference to `configfs_unregister_subsystem' > > so make NETCONSOLE_DYNAMIC require CONFIGFS_FS=y to fix the build > errors. > > This is one possible fix. > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=37992 > > Reported-by: David Hill Signed-off-by: Randy > Dunlap --- > drivers/net/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- lnx-30-rc3.orig/drivers/net/Kconfig +++ > lnx-30-rc3/drivers/net/Kconfig > @@ -3416,7 +3416,7 @@ config NETCONSOLE > > config NETCONSOLE_DYNAMIC > bool "Dynamic reconfiguration of logging targets" > - depends on NETCONSOLE && SYSFS && CONFIGFS_FS > + depends on NETCONSOLE > && SYSFS && CONFIGFS_FS=y I recall someone already fixed this by adding "select CONFIGFS_FS", who removed it again... :-/