From: WANG Cong <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/core: Convert to current logging forms
Date: Thu, 30 Jun 2011 09:55:51 +0000 (UTC) [thread overview]
Message-ID: <iuhh76$fid$1@dough.gmane.org> (raw)
In-Reply-To: 385ebf7e98e377e6e6c384beb961b65d4a95fb18.1309289792.git.joe@perches.com
On Tue, 28 Jun 2011 12:40:10 -0700, Joe Perches wrote:
> Use pr_fmt, pr_<level>, and netdev_<level> as appropriate.
>
> Coalesce long formats.
...
> + np->name, np->local_port);
> + pr_info("%s: local IP %pI4\n",
> + np->name, &np->local_ip);
> + pr_info("%s: interface '%s'\n",
> + np->name, np->dev_name);
> + pr_info("%s: remote port %d\n",
> + np->name, np->remote_port);
> + pr_info("%s: remote IP %pI4\n",
> + np->name, &np->remote_ip);
> + pr_info("%s: remote ethernet address %pM\n", + np->name,
> np->remote_mac);
> }
This doesn't have much value, because the name of the netpoll
user (np->name) is already logged. If we changed it,
we would see "netconsole: netconsole: blah blah...".
Thanks.
next prev parent reply other threads:[~2011-06-30 9:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 19:40 [PATCH] net/core: Convert to current logging forms Joe Perches
2011-06-28 20:21 ` Ben Hutchings
2011-06-28 20:31 ` Joe Perches
2011-06-28 20:36 ` Ben Hutchings
2011-06-28 20:40 ` Joe Perches
2011-06-28 21:37 ` Joe Perches
2011-06-28 21:49 ` Stephen Hemminger
2011-06-28 21:55 ` Joe Perches
2011-06-29 11:11 ` Neil Horman
2011-06-29 11:55 ` David Miller
2011-06-29 15:24 ` Neil Horman
2011-06-29 14:57 ` Joe Perches
2011-06-30 9:55 ` WANG Cong [this message]
2011-06-30 17:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='iuhh76$fid$1@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).