From: Andreas Schwab <schwab@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Netdev <netdev@oss.sgi.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
"David S. Miller" <davem@redhat.com>,
Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
Arjan van de Ven <arjanv@redhat.com>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] remove net driver ugliness that sparse complains about
Date: Sat, 29 May 2004 20:31:17 +0200 [thread overview]
Message-ID: <jeaczraxvu.fsf@sykes.suse.de> (raw)
In-Reply-To: <40B8D2F8.6090905@pobox.com> (Jeff Garzik's message of "Sat, 29 May 2004 14:14:16 -0400")
Jeff Garzik <jgarzik@pobox.com> writes:
> @@ -3680,7 +3680,7 @@
> case SIOCETHTOOL:
> return bond_ethtool_ioctl(bond_dev, ifr);
> case SIOCGMIIPHY:
> - mii = (struct mii_ioctl_data *)&ifr->ifr_data;
> + mii = if_mii(&ifr);
> if (!mii) {
> return -EINVAL;
> }
> @@ -3691,7 +3691,7 @@
> * We do this again just in case we were called by SIOCGMIIREG
> * instead of SIOCGMIIPHY.
> */
> - mii = (struct mii_ioctl_data *)&ifr->ifr_data;
> + mii = if_mii(&ifr);
These two look wrong, too many &.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2004-05-29 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-29 18:14 [PATCH] remove net driver ugliness that sparse complains about Jeff Garzik
2004-05-29 18:23 ` Linus Torvalds
2004-05-29 20:42 ` viro
2004-05-29 20:52 ` viro
2004-05-30 3:25 ` Linus Torvalds
2004-05-29 18:31 ` Andreas Schwab [this message]
2004-05-29 20:00 ` Jeff Garzik
2004-05-29 20:44 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeaczraxvu.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=akpm@osdl.org \
--cc=arjanv@redhat.com \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).