* Fix error checking in niu driver
@ 2008-07-29 18:58 Andreas Schwab
2008-07-30 6:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2008-07-29 18:58 UTC (permalink / raw)
To: netdev
The callers of niu_ethflow_to_class expect zero as error, but it returns
-1 instead.
Signed-off-by: Andreas Schwab <schwab@suse.de>
---
diff --git a/drivers/net/niu.c b/drivers/net/niu.c
index 8ee7d7b..e4765b7 100644
--- a/drivers/net/niu.c
+++ b/drivers/net/niu.c
@@ -6417,7 +6417,7 @@ static int niu_ethflow_to_class(int flow_type, u64 *class)
*class = CLASS_CODE_SCTP_IPV6;
break;
default:
- return -1;
+ return 0;
}
return 1;
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Fix error checking in niu driver
2008-07-29 18:58 Fix error checking in niu driver Andreas Schwab
@ 2008-07-30 6:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-07-30 6:59 UTC (permalink / raw)
To: schwab; +Cc: netdev
From: Andreas Schwab <schwab@suse.de>
Date: Tue, 29 Jul 2008 20:58:14 +0200
> The callers of niu_ethflow_to_class expect zero as error, but it returns
> -1 instead.
>
> Signed-off-by: Andreas Schwab <schwab@suse.de>
Applied, thanks Andreas.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-30 6:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-29 18:58 Fix error checking in niu driver Andreas Schwab
2008-07-30 6:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).