From: Andreas Schwab <schwab@suse.de>
To: Ananda Raju <Ananda.Raju@neterion.com>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org,
leonid.grossman@neterion.com, ravinandan.arakali@neterion.com,
rapuru.sriram@neterion.com, alicia.pena@neterion.com
Subject: Re: [patch 4/5] s2io driver updates
Date: Sun, 13 May 2007 15:22:13 +0200 [thread overview]
Message-ID: <jer6pkoo3e.fsf@sykes.suse.de> (raw)
In-Reply-To: <Pine.GSO.4.10.10604211918060.16549-100000@guinness> (Ananda Raju's message of "Fri\, 21 Apr 2006 19\:20\:22 -0400 \(EDT\)")
Ananda Raju <Ananda.Raju@neterion.com> writes:
> @@ -2704,6 +2792,10 @@ static void tx_intr_handler(fifo_info_t
> if (txdlp->Control_1 & TXD_T_CODE) {
> unsigned long long err;
> err = txdlp->Control_1 & TXD_T_CODE;
> + if (err & 0x1) {
This is never true.
> @@ -5743,6 +6246,11 @@ static int rx_osm_handler(ring_info_t *r
> skb->dev = dev;
>
> if (err) {
> + /* Check for parity error */
> + if (err & 0x1) {
Likewise.
(This is a very old patch, but the issue is still present.)
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2007-05-13 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 23:20 [patch 4/5] s2io driver updates Ananda Raju
2007-05-13 13:22 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jer6pkoo3e.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=Ananda.Raju@neterion.com \
--cc=alicia.pena@neterion.com \
--cc=jgarzik@pobox.com \
--cc=leonid.grossman@neterion.com \
--cc=netdev@vger.kernel.org \
--cc=rapuru.sriram@neterion.com \
--cc=ravinandan.arakali@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).