From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [PATCH 02.5] mm: sl[au]b: first remove PFMEMALLOC flag then SLAB flag Date: Sat, 16 Jun 2012 08:14:10 +0000 (UTC) Message-ID: References: <1337266231-8031-1-git-send-email-mgorman@suse.de> <1337266231-8031-3-git-send-email-mgorman@suse.de> <20120615155432.GA5498@breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org,linux-kernel@vger.kernel.org To: linux-mm@kvack.org Return-path: Sender: owner-linux-mm@kvack.org List-Id: netdev.vger.kernel.org On Fri, 15 Jun 2012 at 15:54 GMT, Sebastian Andrzej Siewior wrote: > From: Sebastian Andrzej Siewior > > If we first remove the SLAB flag followed by the PFMEMALLOC flag then the > removal of the latter will trigger the VM_BUG_ON() as it can be seen in >| kernel BUG at include/linux/page-flags.h:474! >| invalid opcode: 0000 [#1] PREEMPT SMP >| Call Trace: >| [] slab_destroy+0x27/0x70 >| [] drain_freelist+0x55/0x90 >| [] __cache_shrink+0x6e/0x90 >| [] ? acpi_sleep_init+0xcf/0xcf >| [] kmem_cache_shrink+0x2d/0x40 > > because the SLAB flag is gone. This patch simply changes the order. > It would be nicer if we add some comments in the code. ;) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org