* [PATCH 1/2 resend] igb: dobule increment nr_frags
@ 2010-04-15 9:06 Koki Sanagi
2010-04-15 18:03 ` Jeff Kirsher
0 siblings, 1 reply; 2+ messages in thread
From: Koki Sanagi @ 2010-04-15 9:06 UTC (permalink / raw)
To: netdev, e1000-devel
Cc: davem, jeffrey.t.kirsher, jesse.brandeburg, bruce.w.allan,
peter.p.waskiewicz.jr, john.ronciak, Taku Izumi
Previous patch has some mail format problem.
Maybe I've fixed and re-sent.
There is no need to increment nr_frags becasue skb_fill_page_desc increments
it.
Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
---
drivers/net/igb/igb_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index 78cc742..8bde6c3 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -5254,7 +5254,7 @@ static bool igb_clean_rx_irq_adv(struct igb_q_vector *q_vector,
PAGE_SIZE / 2, PCI_DMA_FROMDEVICE);
buffer_info->page_dma = 0;
- skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++,
+ skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
buffer_info->page,
buffer_info->page_offset,
length);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2 resend] igb: dobule increment nr_frags
2010-04-15 9:06 [PATCH 1/2 resend] igb: dobule increment nr_frags Koki Sanagi
@ 2010-04-15 18:03 ` Jeff Kirsher
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Kirsher @ 2010-04-15 18:03 UTC (permalink / raw)
To: Koki Sanagi
Cc: netdev, e1000-devel, davem, jesse.brandeburg, bruce.w.allan,
john.ronciak, Taku Izumi
On Thu, Apr 15, 2010 at 02:06, Koki Sanagi <sanagi.koki@jp.fujitsu.com> wrote:
> Previous patch has some mail format problem.
> Maybe I've fixed and re-sent.
>
> There is no need to increment nr_frags becasue skb_fill_page_desc increments
> it.
>
> Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
> ---
> drivers/net/igb/igb_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Thanks, I have added the patch to my queue of patches.
--
Cheers,
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-15 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-15 9:06 [PATCH 1/2 resend] igb: dobule increment nr_frags Koki Sanagi
2010-04-15 18:03 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).