netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: fix bond 6 mode change MAC of arp reply from vif to cause Domu's network unreachable intermittently
Date: Tue, 30 Oct 2012 03:03:05 +0000 (UTC)	[thread overview]
Message-ID: <k6ng19$fvd$1@ger.gmane.org> (raw)
In-Reply-To: 1351565271-5888-1-git-send-email-zheng.x.li@oracle.com

On Tue, 30 Oct 2012 at 02:47 GMT, Zheng Li <zheng.x.li@oracle.com> wrote:
> +			struct slave *tmp_slave = NULL;
> +			int i = 0, found_mac = 0;
> +			bond_for_each_slave(bond, tmp_slave, i) {
> +				if (ether_addr_equal_64bits(arp->mac_src,
> +						tmp_slave->dev->dev_addr)) {
> +					found_mac = 1;
> +					break;
> +				}
> +			}
> +			if (found_mac)
> +				memcpy(arp->mac_src, tx_slave->dev->dev_addr,
> +					ETH_ALEN);

A nitpick: found_mac can be a bool.

  reply	other threads:[~2012-10-30  3:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-30  2:47 [PATCH] bonding: fix bond 6 mode change MAC of arp reply from vif to cause Domu's network unreachable intermittently Zheng Li
2012-10-30  3:03 ` Cong Wang [this message]
2012-10-30 19:39 ` Jay Vosburgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='k6ng19$fvd$1@ger.gmane.org' \
    --to=xiyou.wangcong@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).