From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: [PATCH net-next V4 03/13] bridge: Validate that vlan is permitted on ingress
Date: Thu, 20 Dec 2012 07:27:11 +0000 (UTC) [thread overview]
Message-ID: <kaueke$69b$1@ger.gmane.org> (raw)
In-Reply-To: 1355939304-21804-4-git-send-email-vyasevic@redhat.com
On Wed, 19 Dec 2012 at 17:48 GMT, Vlad Yasevich <vyasevic@redhat.com> wrote:
> +static inline u16 br_get_vlan(const struct sk_buff *skb)
> +{
> + u16 tag;
> +
> + if (vlan_tx_tag_present(skb))
> + return vlan_tx_tag_get(skb) & VLAN_VID_MASK;
> +
> + if (vlan_get_tag(skb, &tag))
> + return 0;
> +
> + return tag & VLAN_VID_MASK;
> +}
> +
Nitpick:
The name br_get_vlan() can easily confuse people with br_vlan_find().
Also, this function looks like not bridge-specific, how about moving
it to if_vlan.h?
next prev parent reply other threads:[~2012-12-20 7:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 17:48 [PATCH net-next V4 00/13] Add basic VLAN support to bridges Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 01/13] vlan: wrap hw-acceleration calls in separate functions Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 02/13] bridge: Add vlan filtering infrastructure Vlad Yasevich
2012-12-20 13:39 ` Shmulik Ladkani
2012-12-20 15:31 ` Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 03/13] bridge: Validate that vlan is permitted on ingress Vlad Yasevich
2012-12-20 7:27 ` Cong Wang [this message]
2012-12-20 14:07 ` Shmulik Ladkani
2012-12-20 15:41 ` Vlad Yasevich
2012-12-20 16:24 ` Shmulik Ladkani
2012-12-20 16:54 ` Vlad Yasevich
2012-12-20 20:13 ` Shmulik Ladkani
2012-12-21 4:48 ` Shmulik Ladkani
2012-12-19 17:48 ` [PATCH net-next V4 04/13] bridge: Verify that a vlan is allowed to egress on give port Vlad Yasevich
2012-12-20 14:28 ` Shmulik Ladkani
2012-12-19 17:48 ` [PATCH net-next V4 05/13] bridge: Cache vlan in the cb for faster egress lookup Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 06/13] bridge: Add vlan to unicast fdb entries Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 07/13] bridge: Add vlan id to multicast groups Vlad Yasevich
2012-12-20 8:05 ` Cong Wang
2012-12-19 17:48 ` [PATCH net-next V4 08/13] bridge: Add netlink interface to configure vlans on bridge ports Vlad Yasevich
2012-12-20 7:48 ` Cong Wang
2012-12-19 17:48 ` [PATCH net-next V4 09/13] bridge: Add vlan support to static neighbors Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 10/13] bridge: Add the ability to configure untagged vlans Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 11/13] bridge: Implement untagged vlan handling Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 12/13] bridge: Dump vlan information from a bridge port Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 13/13] bridge: Add vlan support for local fdb entries Vlad Yasevich
2012-12-19 22:54 ` [PATCH net-next V4 00/13] Add basic VLAN support to bridges Andrew Collins
2012-12-19 22:58 ` Vlad Yasevich
2012-12-20 10:08 ` Vitalii Demianets
2012-12-20 17:07 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='kaueke$69b$1@ger.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).