From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: regression caused by 1d2024f61ec14bdb0c57a97a3fe73685abc2d198?
Date: Thu, 7 Feb 2013 03:03:40 +0000 (UTC) [thread overview]
Message-ID: <kev5ic$tla$1@ger.gmane.org> (raw)
In-Reply-To: 20130206174228.GA16991@redhat.com
On Wed, 06 Feb 2013 at 17:42 GMT, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> I see it sets gso_type but apparently only if mode is GRO?
> Will this still break if mode is set to LRO?
The comment inside skb_warn_if_lro() said:
/* LRO sets gso_size but not gso_type, whereas if GSO is really
* wanted then gso_type will be set. */
next prev parent reply other threads:[~2013-02-07 3:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 11:43 regression caused by 1d2024f61ec14bdb0c57a97a3fe73685abc2d198? Michael S. Tsirkin
2013-02-06 13:07 ` Eric Dumazet
2013-02-06 15:50 ` Michael S. Tsirkin
2013-02-06 16:15 ` Eric Dumazet
2013-02-06 17:42 ` Michael S. Tsirkin
2013-02-06 17:42 ` Eric Dumazet
2013-02-06 17:50 ` Michael S. Tsirkin
2013-02-06 18:05 ` Michael S. Tsirkin
2013-02-06 18:09 ` Eric Dumazet
2013-02-07 3:03 ` Cong Wang [this message]
2013-02-06 16:23 ` Eric Dumazet
2013-02-06 19:58 ` Ben Hutchings
2013-02-06 21:45 ` Michael S. Tsirkin
2013-02-06 21:55 ` Ben Hutchings
2013-02-06 22:26 ` Michael S. Tsirkin
2013-02-06 23:29 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='kev5ic$tla$1@ger.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).