From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 5/5] sock_diag: notify when filter change
Date: Wed, 24 Apr 2013 08:05:15 +0000 (UTC) [thread overview]
Message-ID: <kl83nr$8t3$1@ger.gmane.org> (raw)
In-Reply-To: 1366727277-19522-6-git-send-email-nicolas.dichtel@6wind.com
On Tue, 23 Apr 2013 at 14:27 GMT, Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> @@ -773,6 +775,7 @@ int sk_detach_filter(struct sock *sk)
> RCU_INIT_POINTER(sk->sk_filter, NULL);
> sk_filter_uncharge(sk, filter);
> ret = 0;
> + sock_diag_notify(sk, 1);
Should be sock_diag_notify(sk, 0)?
BTW, use 'true' and 'false' instead of '1' and '0'.
next prev parent reply other threads:[~2013-04-24 8:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 14:27 [PATCH net-next 0/5] sock_diag: monitor packet sockets Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 1/5] packet_diag: disclose uid value Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 2/5] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 3/5] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-23 15:31 ` Eric Dumazet
2013-04-23 14:27 ` [PATCH net-next 4/5] sock_diag: notify packet socket creation/deletion Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 5/5] sock_diag: notify when filter change Nicolas Dichtel
2013-04-24 8:05 ` Cong Wang [this message]
2013-04-24 8:13 ` Nicolas Dichtel
2013-04-24 15:52 ` [PATCH net-next v2 0/5] sock_diag: monitor packet sockets Nicolas Dichtel
2013-04-24 15:52 ` [PATCH net-next v2 1/5] packet_diag: disclose uid value Nicolas Dichtel
2013-04-24 15:52 ` [PATCH net-next v2 2/5] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-24 15:52 ` [PATCH net-next v2 3/5] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-24 16:22 ` Eric Dumazet
2013-04-25 5:16 ` David Miller
2013-04-25 8:37 ` Nicolas Dichtel
2013-04-25 9:00 ` David Miller
2013-04-25 13:21 ` [PATCH net-next v3 0/4] sock_diag: monitor packet sockets Nicolas Dichtel
2013-04-25 13:21 ` [PATCH net-next v3 1/4] packet_diag: disclose uid value Nicolas Dichtel
2013-04-25 13:21 ` [PATCH net-next v3 2/4] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-25 13:21 ` [PATCH net-next v3 3/4] sock_diag: do not disclose sock ptr to all users Nicolas Dichtel
2013-04-25 15:32 ` Eric Dumazet
2013-04-25 15:36 ` Eric Dumazet
2013-04-25 16:45 ` Nicolas Dichtel
2013-04-25 16:57 ` Eric Dumazet
2013-04-25 16:53 ` [PATCH net-next v4 0/3] packet_diag: enhance advertised infos Nicolas Dichtel
2013-04-25 16:53 ` [PATCH net-next v4 1/3] packet_diag: disclose uid value Nicolas Dichtel
2013-04-25 16:53 ` [PATCH net-next v4 2/3] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-25 16:53 ` [PATCH net-next v4 3/3] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-29 17:22 ` [PATCH net-next v4 0/3] packet_diag: enhance advertised infos David Miller
2013-04-25 13:21 ` [PATCH net-next v3 4/4] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-25 13:51 ` [PATCH net-next v2 3/5] " Eric Dumazet
2013-04-24 15:52 ` [PATCH net-next v2 4/5] sock_diag: notify packet socket creation/deletion Nicolas Dichtel
2013-05-17 14:25 ` [PATCH net-next v3] " Nicolas Dichtel
2013-05-20 6:29 ` David Miller
2013-05-21 15:14 ` Nicolas Dichtel
2013-05-21 18:43 ` David Miller
2013-05-22 11:49 ` Nicolas Dichtel
2013-04-24 15:52 ` [PATCH net-next v2 5/5] sock_diag: notify when filter change Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='kl83nr$8t3$1@ger.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).