From: Cong Wang <xiyou.wangcong@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net v2 2/3] unix/dgram: fix peeking with an offset larger than data in queue
Date: Mon, 29 Apr 2013 07:01:39 +0000 (UTC) [thread overview]
Message-ID: <kll5si$544$1@ger.gmane.org> (raw)
In-Reply-To: 1367001312-6719-2-git-send-email-bpoirier@suse.de
On Fri, 26 Apr 2013 at 18:35 GMT, Benjamin Poirier <bpoirier@suse.de> wrote:
> struct sk_buff *__skb_recv_datagram(struct sock *sk, unsigned int flags,
> - int *peeked, int *off, int *err)
> + int *peeked, int *_off, int *err)
> {
> - struct sk_buff *skb;
> + struct sk_buff *skb, *last;
> long timeo;
> /*
> * Caller is allowed not to check sk->sk_err before skb_recv_datagram()
> @@ -182,14 +183,17 @@ struct sk_buff *__skb_recv_datagram(struct sock *sk, unsigned int flags,
> */
> unsigned long cpu_flags;
> struct sk_buff_head *queue = &sk->sk_receive_queue;
> + int off = *_off;
>
Name the local variable '_off', not the function argument.
Or pick another name, e.g. 'offset'.
next prev parent reply other threads:[~2013-04-29 7:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 13:47 [PATCH net 1/3] unix/dgram: peek beyond 0-sized skbs Benjamin Poirier
2013-04-25 13:47 ` [PATCH net 2/3] unix/dgram: fix peeking with an offset larger than data in queue Benjamin Poirier
2013-04-25 18:58 ` Eric Dumazet
2013-04-25 13:47 ` [PATCH net 3/3] unix/stream: " Benjamin Poirier
2013-04-25 18:48 ` [PATCH net 1/3] unix/dgram: peek beyond 0-sized skbs Eric Dumazet
2013-04-26 18:35 ` Benjamin Poirier
2013-04-26 18:35 ` [PATCH net v2 2/3] unix/dgram: fix peeking with an offset larger than data in queue Benjamin Poirier
2013-04-29 7:01 ` Cong Wang [this message]
2013-04-29 21:42 ` [PATCH v3 1/3] unix/dgram: peek beyond 0-sized skbs Benjamin Poirier
2013-04-29 21:42 ` [PATCH v3 2/3] unix/dgram: fix peeking with an offset larger than data in queue Benjamin Poirier
2013-04-30 0:49 ` Eric Dumazet
2013-04-30 4:44 ` David Miller
2013-04-29 21:42 ` [PATCH v3 3/3] unix/stream: " Benjamin Poirier
2013-04-30 0:51 ` Eric Dumazet
2013-04-30 4:44 ` David Miller
2013-04-30 0:48 ` [PATCH v3 1/3] unix/dgram: peek beyond 0-sized skbs Eric Dumazet
2013-04-30 4:44 ` David Miller
2013-04-26 18:35 ` [PATCH net v2 3/3] unix/stream: fix peeking with an offset larger than data in queue Benjamin Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='kll5si$544$1@ger.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).