From: Cong Wang <xiyou.wangcong@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: KVM VM shutdown triggers BUG from network bridge code in 3.9.9
Date: Fri, 5 Jul 2013 08:31:43 +0000 (UTC) [thread overview]
Message-ID: <kr609f$aon$1@ger.gmane.org> (raw)
In-Reply-To: 51D64BEC.7090208@gmail.com
On Fri, 05 Jul 2013 at 04:30 GMT, Robert Hancock <hancockrwd@gmail.com> wrote:
> I've run into a problem after updating to Fedora 19 where if I shut down
> a Windows 7 KVM virtual machine, the machine hits a kernel panic. There
> are a few reports of this on 3.9.8 and 3.9.9 kernels here:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=981437
>
> The panic is "kernel BUG at kernel/timer.c:729!" and the stack traces
> all seem basically the same, something like this one (captured with kdump):
>
> #7 [ffff880214d25c10] mod_timer+501 at ffffffff8106d905
> #8 [ffff880214d25c50] br_multicast_del_pg.isra.20+261 at
> ffffffffa0731d25 [bridge]
Yeah, I got some similar bug report on Fedora...
Could you try the following patch? Thanks!
----------
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 81befac..69af490 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -270,7 +270,7 @@ static void br_multicast_del_pg(struct net_bridge *br,
del_timer(&p->timer);
call_rcu_bh(&p->rcu, br_multicast_free_pg);
- if (!mp->ports && !mp->mglist &&
+ if (!mp->ports && !mp->mglist && mp->timer_armed &&
netif_running(br->dev))
mod_timer(&mp->timer, jiffies);
prev parent reply other threads:[~2013-07-05 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 4:30 KVM VM shutdown triggers BUG from network bridge code in 3.9.9 Robert Hancock
2013-07-05 8:31 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='kr609f$aon$1@ger.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).