From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: [PATCH net v2] gso: Update tunnel segmentation to support Tx checksum offload
Date: Thu, 11 Jul 2013 02:23:31 +0000 (UTC) [thread overview]
Message-ID: <krl4v3$o8d$1@ger.gmane.org> (raw)
In-Reply-To: 1373503334.4600.27.camel@edumazet-glaptop
On Thu, 11 Jul 2013 at 00:42 GMT, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Wed, 2013-07-10 at 17:05 -0700, Alexander Duyck wrote:
>> This change makes it so that the GRE and VXLAN tunnels can make use of Tx
>> checksum offload support provided by some drivers via the hw_enc_features.
>> Without this fix enabling GSO means sacrificing Tx checksum offload and
>> this actually leads to a performance regression as shown below:
>>
>> Utilization
>> Send
>> Throughput local GSO
>> 10^6bits/s % S state
>> 6276.51 8.39 enabled
>> 7123.52 8.42 disabled
>
> While testing your patch, I discovered TSO support is completely broken
> on GRE, using bnx2x testbed.
>
In my test, GRE works fine, but gretap not.
next prev parent reply other threads:[~2013-07-11 2:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 0:05 [PATCH net v2] gso: Update tunnel segmentation to support Tx checksum offload Alexander Duyck
2013-07-11 0:42 ` Eric Dumazet
2013-07-11 1:43 ` Eric Dumazet
2013-07-11 2:30 ` Alexander Duyck
2013-07-11 2:37 ` Eric Dumazet
2013-07-11 2:23 ` Cong Wang [this message]
2013-07-11 7:45 ` Pravin Shelar
2013-07-11 8:14 ` David Miller
2013-07-11 8:31 ` Dmitry Kravkov
2013-07-11 13:51 ` Eric Dumazet
2013-07-11 17:58 ` Alexander Duyck
2013-07-11 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='krl4v3$o8d$1@ger.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).