From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: [PATCH net] gre: Fix MTU sizing check for gretap tunnels
Date: Fri, 12 Jul 2013 01:11:16 +0000 (UTC) [thread overview]
Message-ID: <krnl3j$d9l$1@ger.gmane.org> (raw)
In-Reply-To: 20130711201152.8775.40579.stgit@ahduyck-hc1.jf.intel.com
On Thu, 11 Jul 2013 at 20:12 GMT, Alexander Duyck <alexander.h.duyck@intel.com> wrote:
> This change fixes an MTU sizing issue seen with gretap tunnels when non-gso
> packets are sent from the interface.
>
> In my case I was able to reproduce the issue by simply sending a ping of
> 1421 bytes with the gretap interface created on a device with a standard
> 1500 mtu.
>
> This fix is based on the fact that the tunnel mtu is already adjusted by
> dev->hard_header_len so it would make sense that any packets being compared
> against that mtu should also be adjusted by hard_header_len and the tunnel
> header instead of just the tunnel header.
>
This patch indeed fixes the performance problem I reported, nice work!
Thanks for the patch, Alexander!
prev parent reply other threads:[~2013-07-12 1:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 20:12 [PATCH net] gre: Fix MTU sizing check for gretap tunnels Alexander Duyck
2013-07-11 21:52 ` Eric Dumazet
2013-07-11 23:30 ` David Miller
2013-07-11 22:24 ` Pravin Shelar
2013-07-11 22:45 ` Eric Dumazet
2013-07-11 23:19 ` Pravin Shelar
2013-07-11 23:30 ` David Miller
2013-07-11 23:36 ` Jesse Gross
2013-07-12 0:13 ` Alexander Duyck
2013-07-12 1:11 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='krnl3j$d9l$1@ger.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).