From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [RFC PATCH - diffstat only] include/net: Remove extern from function prototypes Date: Thu, 25 Jul 2013 01:27:49 +0000 (UTC) Message-ID: References: <1374602291.3387.17.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: linux-kernel@vger.kernel.org Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 23 Jul 2013 at 17:58 GMT, Joe Perches wrote: > Function prototypes don't need to be declared > extern in .h files. It's assumed by the compiler > and is as unnecessary as using auto is when > declaring automatic/local variables in a block. > Since we all know this, why bother it? Having "extern" doesn't harm readability, instead it probably helps. ... > > I believe it makes grepping for extern useful as > all the matches are actual variables and structs. > You need a semantic tool.