From: James Huang <jamesclhuang@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: LRO restructuring?
Date: Thu, 19 Feb 2009 22:20:53 +0000 (UTC) [thread overview]
Message-ID: <loom.20090219T221928-196@post.gmane.org> (raw)
In-Reply-To: 20090219135358.GA11319@gondor.apana.org.au
Hi all,
One question about inet_lro.c (linux 2.6.28.6)
In lro_proc_segment(), it does not check the number of available frags entries
in lro_desc->parent against the number of new fragments to be added before
calling lro_add_frags(). Is that a bug? I see that lro_proc_segment() does
some type of checking at the end, but could that be too late (i.e. overflow
the frags[])??
Also I think some obvious optimization in lro_get_desc() can be done by
combining the two for loops into one.
-- James Huang
next prev parent reply other threads:[~2009-02-19 22:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 13:30 LRO restructuring? Andrew Gallatin
2008-08-11 21:03 ` David Miller
2008-08-12 11:50 ` Andrew Gallatin
2008-08-13 2:14 ` Herbert Xu
2008-08-12 0:50 ` Herbert Xu
2008-08-12 0:54 ` David Miller
2008-08-12 1:00 ` Herbert Xu
2008-08-12 1:30 ` Rick Jones
2008-08-12 1:39 ` David Miller
2008-08-12 1:53 ` Herbert Xu
2009-02-18 19:25 ` James Huang
2009-02-18 19:42 ` Ben Hutchings
2009-02-18 19:46 ` Stephen Hemminger
2009-02-19 13:53 ` Herbert Xu
2009-02-19 22:20 ` James Huang [this message]
[not found] ` <f0ed9b110902191417k2917d856q9098b304eeb7435b@mail.gmail.com>
2009-02-20 0:37 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20090219T221928-196@post.gmane.org \
--to=jamesclhuang@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).