From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E05D33991 for ; Tue, 2 Sep 2025 02:34:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756780475; cv=none; b=hIXAIpFllpPZN8q0KF/fdfK+cQYj4b2/9x19+5zbfn5Tcn9T/uQ1PXRQnRHUBVGbRCL2pP5Ao7ZBrVP1ixrBFPDAVPOJDrzdBl2ss2kkcIru6lmWLUnyo0qproI0pubX+wHq1Bv94D51/OIG6OGm8uCthXwJwCvufQOCKgYJvHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756780475; c=relaxed/simple; bh=da4uTNhiqePv0Xg9eLwNKjRKFjWWOOVrp+AzpZL2hy4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WxsdEFzLiobpk9f+O+zR/ZeKgngpCY1ZLtCiC4gbNJGky3YAehGGVTHeWlOVP6hkSzbpx1SZsRCP7qFAXrIn1y0ACAvzN4SrGNlgKMQuVbluoN7qOvfY67dJcm5msHtxCuNDEMtdu0Hhap3vKyYIzVfBNVxJHjIv8VfLxNhP1sU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RhYX4Xu7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RhYX4Xu7" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5822S6Su030132 for ; Tue, 2 Sep 2025 02:34:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vS0F+s8gHxST2GOfLmUKRNqUAeMPii9K1GmPXyJtBXE=; b=RhYX4Xu7SpXM/EDh E7fuhwt6QyQakbMwxU7oBL4DfKv+4MPu144oSL5xwRrI8BaDOYQWnNPK3M3Idr8W kwbeZ3tY0CETMTw5qaiPOwSVhOcLLJ7zTVbwTXVuq7QjuPpMZddlLH7Vrz85q7b2 9uTZQ3LiC7zmkTslRB8C5FkAs2z9hvcsvDhsmzPGQ0PK6riLBOvQXA7W3A1egrJd IPfA65WzKG+O06hscRvDEYEh+xWnmoW8oCER1a4zwWdws20zLplr+wL4dcEI+1uK 1hHqY27u8KrbaZaTr6t91AoM7pz3gocWwpuDgIFxQ5l7HdIvuvfDC4M5MQiY5af9 zxpSPw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48w8wy21q8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 02 Sep 2025 02:34:32 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4b345aff439so8316681cf.0 for ; Mon, 01 Sep 2025 19:34:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756780472; x=1757385272; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vS0F+s8gHxST2GOfLmUKRNqUAeMPii9K1GmPXyJtBXE=; b=AVhtFyFYvPYFhRX9Irb8oLNGtgD+v4wqFVqpjMW9DccaXsJ51mMlR0vL1xPD1YXcE2 4+RkQUY/4OTFiXP8zkEHVqdmRv9Z4iSeWY9ZXEsw2c26lKAapp0Rd9Ki5f+T5PV+698T oIyO/tx3i1Mrz4kL+wX3GvtoPlF5ExFR5lh/W7PM9fFDlewz2wlmLov+toNAS4LIEqd+ Wq9HzWcV1+3gONHUBDsr/cYNz3iG8onrSO8lVGr8gUD2pO6oA3sku6sHwhDBhisPXjr1 zoriWgg6qBI67d6RsfIuyWi7n1qhP4JOAQKedIKqlnOUyb0p9ptUB9ErzBAYLsYK8Lqq iBIw== X-Forwarded-Encrypted: i=1; AJvYcCVWQsjK13JpJZwVjq3Ux7wKpCHqRGlar4LNqugLO6U6CxsEaUPUiQ+FdF4Hs4V05xfIyJ5Wmf4=@vger.kernel.org X-Gm-Message-State: AOJu0YxGteM6isj2AOEu94y5KcdwT4RwTdZmnT5DzA+gFVoJ0AXk2eZh urYT2rsyV4HZYBzcHTCy4u4z3riA/eFAQDbaI7UYoHZZLMGjBCljmB3YvY6q9PH3LisKylgYtnB YwhOb4TxxU8wdYYJSvqnSe7v/eyz6FkZVrxOmtCZD8d2uV5XnCdrfP69hJzw= X-Gm-Gg: ASbGncsH7tree3zcdHb6MMXo1n2rg4eDwXFbCMeb5SWIS70K7XltBthGwMuV9K+Z7yF mKzi/SclzFDq45PNclzrLtV7qg82ccOlIRsJffBpUBYFfAa1tchUAfwqpkcLRh44VVs8cWskC6k OtgFS0jeMjLdov3gGDux55zzHUfimFymuleFbaYpm9YYVirhxD4bHTo/BeSEIGdWs32weiedfnc F0lm/ct73sXF8zuVUT60wMIrp4fKWo7+x3NLirQwxMoebVyThOdunuvuyj7gkzh6eNgbS3AuLon ZrjDYzdoTHFYfwCWoVlX+WnkyyBIqIHXHopLkL3gzh+GMylp3QcJ16o7hk7+hb34MWvE4RTJ1zJ h6zveXIHhXeXF4NX1OwJ2rCtpXw46p2Pz7KJoyZcsoATaAgt9fT0x X-Received: by 2002:a05:622a:230c:b0:4b3:1847:4192 with SMTP id d75a77b69052e-4b31dd2f96fmr131936831cf.69.1756780471846; Mon, 01 Sep 2025 19:34:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzqodcfWhpK6qJYUt42vLlLnCY1b1EAphCtxu0+mddayjBUMwightL8KwYc5BxzP8zvbba9w== X-Received: by 2002:a05:622a:230c:b0:4b3:1847:4192 with SMTP id d75a77b69052e-4b31dd2f96fmr131936501cf.69.1756780471342; Mon, 01 Sep 2025 19:34:31 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-560827a0218sm281176e87.117.2025.09.01.19.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Sep 2025 19:34:30 -0700 (PDT) Date: Tue, 2 Sep 2025 05:34:27 +0300 From: Dmitry Baryshkov To: Krishna Kurapati PSSNV Cc: Monish Chunara , Sushrut Shree Trivedi , Wasim Nazir , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Richard Cochran , kernel@oss.qualcomm.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, Viken Dadhaniya , Nirmesh Kumar Singh , Mohd Ayaan Anwar , Dikshita Agarwal , Vishal Kumar Pal Subject: Re: [PATCH 3/5] arm64: dts: qcom: lemans-evk: Extend peripheral and subsystem support Message-ID: References: <20250826-lemans-evk-bu-v1-0-08016e0d3ce5@oss.qualcomm.com> <20250826-lemans-evk-bu-v1-3-08016e0d3ce5@oss.qualcomm.com> <3f94ccc8-ac8a-4c62-8ac6-93dd603dcd36@quicinc.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Authority-Analysis: v=2.4 cv=Ycq95xRf c=1 sm=1 tr=0 ts=68b657b8 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=FAQitTM21wLSu42_UfgA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: 8uiS3gfIArAu3U1Yi9l4SVTwphk_9_ND X-Proofpoint-ORIG-GUID: 8uiS3gfIArAu3U1Yi9l4SVTwphk_9_ND X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAxMDEwMSBTYWx0ZWRfX47iRS8ceftx9 tLw6r0uqML+T33dqO7nL0oudea3Zlof9+9z8yt1AWuR0+tzBw6uRv7jLPyZLWgCL5r4wwD8yk8r A4BGhTUEuSVPDeRsQqZWzBNdqSm/jlb+k17xhjfyMA19VZn7nRELeBDKVS6CoPe1sXZLZ36YrYW u1YkBmaUydYJW8ODXDLfP73QbuAf7SbuMbVlYlMPAdxIcvJTh0c2mXtbV6XZarR8XbpOe991gxK /imkgYfz5TKV0WF/HzKMs9fV16g724KOvrPyYeFOObRUHT3KpO6cSfj0czUbNNgczQZmptcAySB 9AmZohFoo5DKA3B1fKLBQhAMYro1g4t8xXEmbMhC8T+0EED/OhtWNN7D0AOAgSHHS2WDqLA2yf/ ZeiJwt2p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-02_01,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509010101 On Mon, Sep 01, 2025 at 01:02:15PM +0530, Krishna Kurapati PSSNV wrote: > > > On 8/29/2025 9:54 PM, Dmitry Baryshkov wrote: > > On Fri, Aug 29, 2025 at 07:50:57PM +0530, Monish Chunara wrote: > > > On Thu, Aug 28, 2025 at 04:30:00PM +0300, Dmitry Baryshkov wrote: > > > > On Thu, Aug 28, 2025 at 06:38:03PM +0530, Sushrut Shree Trivedi wrote: > > > > > > > > > > On 8/27/2025 7:05 AM, Dmitry Baryshkov wrote: > > > > > > On Tue, Aug 26, 2025 at 11:51:02PM +0530, Wasim Nazir wrote: > > > > > > > Enhance the Qualcomm Lemans EVK board file to support essential > > > > > > > peripherals and improve overall hardware capabilities, as > > > > > > > outlined below: > > > > > > > - Enable GPI (Generic Peripheral Interface) DMA-0/1/2 and QUPv3-0/2 > > > > > > > controllers to facilitate DMA and peripheral communication. > > > > > > > - Add support for PCIe-0/1, including required regulators and PHYs, > > > > > > > to enable high-speed external device connectivity. > > > > > > > - Integrate the TCA9534 I/O expander via I2C to provide 8 additional > > > > > > > GPIO lines for extended I/O functionality. > > > > > > > - Enable the USB0 controller in device mode to support USB peripheral > > > > > > > operations. > > > > > > > - Activate remoteproc subsystems for supported DSPs such as Audio DSP, > > > > > > > Compute DSP-0/1 and Generic DSP-0/1, along with their corresponding > > > > > > > firmware. > > > > > > > - Configure nvmem-layout on the I2C EEPROM to store data for Ethernet > > > > > > > and other consumers. > > > > > > > - Enable the QCA8081 2.5G Ethernet PHY on port-0 and expose the > > > > > > > Ethernet MAC address via nvmem for network configuration. > > > > > > > It depends on CONFIG_QCA808X_PHY to use QCA8081 PHY. > > > > > > > - Add support for the Iris video decoder, including the required > > > > > > > firmware, to enable video decoding capabilities. > > > > > > > - Enable SD-card slot on SDHC. > > > > > > > > > > > > > > Co-developed-by: Viken Dadhaniya > > > > > > > Signed-off-by: Viken Dadhaniya > > > > > > > Co-developed-by: Sushrut Shree Trivedi > > > > > > > Signed-off-by: Sushrut Shree Trivedi > > > > > > > Co-developed-by: Nirmesh Kumar Singh > > > > > > > Signed-off-by: Nirmesh Kumar Singh > > > > > > > Co-developed-by: Krishna Kurapati > > > > > > > Signed-off-by: Krishna Kurapati > > > > > > > Co-developed-by: Mohd Ayaan Anwar > > > > > > > Signed-off-by: Mohd Ayaan Anwar > > > > > > > Co-developed-by: Dikshita Agarwal > > > > > > > Signed-off-by: Dikshita Agarwal > > > > > > > Co-developed-by: Monish Chunara > > > > > > > Signed-off-by: Monish Chunara > > > > > > > Co-developed-by: Vishal Kumar Pal > > > > > > > Signed-off-by: Vishal Kumar Pal > > > > > > > Signed-off-by: Wasim Nazir > > > > > > > --- > > > > > > > arch/arm64/boot/dts/qcom/lemans-evk.dts | 387 ++++++++++++++++++++++++++++++++ > > > > > > > 1 file changed, 387 insertions(+) > > > > > > > > > > > > > > > > > > > > @@ -356,6 +720,29 @@ &ufs_mem_phy { > > > > > > > status = "okay"; > > > > > > > }; > > > > > > > +&usb_0 { > > > > > > > + status = "okay"; > > > > > > > +}; > > > > > > > + > > > > > > > +&usb_0_dwc3 { > > > > > > > + dr_mode = "peripheral"; > > > > > > Is it actually peripheral-only? > > > > > > > > > > Hi Dmitry, > > > > > > > > > > HW supports OTG mode also, but for enabling OTG we need below mentioned > > > > > driver changes in dwc3-qcom.c : > > > > > > > > Is it the USB-C port? If so, then you should likely be using some form > > > > of the Type-C port manager (in software or in hardware). These platforms > > > > usually use pmic-glink in order to handle USB-C. > > > > > > > > Or is it micro-USB-OTG port? > > > > > > > > > > Yes, it is a USB Type-C port for usb0 and we are using a 3rd party Type-C port > > > controller for the same. Will be enabling relevant dts node as part of OTG > > > enablement once driver changes are in place. > > > > Which controller are you using? In the existing designs USB-C works > > without extra patches for the DWC3 controller. > > > > Hi Dmitry, > > On EVK Platform, the VBUS is controlled by a GPIO from expander. Unlike in > other platforms like SA8295 ADP, QCS8300 Ride, instead of keeping vbus > always on for dr_mode as host mode, we wanted to implement vbus control in > dwc3-qcom.c based on top of [1]. In this patch, there is set_role callback > present to turn off/on the vbus. So after this patch is merged, we wanted to > implement vbus control and then flatten DT node and then add vbus supply to > glue node. Hence made peripheral only dr_mode now. In such a case VBUS should be controlled by the USB-C controller rather than DWC3. The reason is pretty simple: the power direction and data direction are not 1:1 related anymore. The Type-C port manager decides whether to supply power over USB-C / Vbus or not and (if supported) which voltage to use. See TCPM's tcpc_dev::set_vbus(). > > [1]: https://lore.kernel.org/all/20250812055542.1588528-3-krishna.kurapati@oss.qualcomm.com/ > > Regards, > Krishna, > > > > > > > > > > > > > > a) dwc3 core callback registration by dwc3 glue driver; this change is under > > > > >     review in upstream. > > > > > b) vbus supply enablement for host mode; this change is yet to be submitted > > > > >     to upstream. > > > > > > > > > > Post the above mentioned driver changes, we are planning to enable OTG on > > > > > usb0. > > > -- With best wishes Dmitry