From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls. Date: Thu, 09 Aug 2007 20:12:14 -0600 Message-ID: References: <20070810.104710.28739250.yoshfuji@linux-ipv6.org> <20070809185521.c3ab1afd.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: YOSHIFUJI Hideaki / =?utf-8?B?5ZCJ6Jek6Iux5piO?= , linux-kernel@vger.kernel.org, devel@openvz.org, adobriyan@sw.ru, netdev@vger.kernel.org, davem@davemloft.net To: Andrew Morton Return-path: Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:48366 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756403AbXHJCNY (ORCPT ); Thu, 9 Aug 2007 22:13:24 -0400 In-Reply-To: <20070809185521.c3ab1afd.akpm@linux-foundation.org> (Andrew Morton's message of "Thu, 9 Aug 2007 18:55:21 -0700") Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Andrew Morton writes: > But it is good to remove bad interfaces, if we possibly can. > > It is worth making the attempt. Does anyone know of anything which will > break? I fed NET_NEIGH_ANYCAST_DELAY at random into > http://www.google.com/codesearch and came up with nothing... My current policy is that since I could only find 5 real world linux programs that even call sys_sysctl, that if I find a broken sysctl binary interface I'm lazy and just remove it. The only networking one I know of is radvd. Added to that I just pushed an autochecking sysctl patch to Andrew that fails register_sysctl_table if the sysctl table is broken. And all of these showed up. So some fix was needed or things would have been even worse. Eric