netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Skywind <gnuwind@gmail.com>
Cc: davem@davemloft.net, casavan@sgi.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Is kernel 2.6.11 adjust tcp_max_syn_backlog incorrectly?
Date: Sat, 11 Jun 2005 12:25:08 +0200	[thread overview]
Message-ID: <m11x79dwcb.fsf@muc.de> (raw)
In-Reply-To: <75052be705060607106a6c0882@mail.gmail.com> (gnuwind@gmail.com's message of "Mon, 6 Jun 2005 22:10:17 +0800")

Skywind <gnuwind@gmail.com> writes:
>
> It seems that kernel don't adjust these value automatic, is this a bug?
>
> I guess the mechanism of tcp.c in 2.6.11 have some changes(between
> 2.6.10), and it conduce to this result,
> Is this guess correctly?

Yes, there were some changes here when it was converted to a common
function for all hash tables (alloc_large_system_hash - the function
with the argument list from hell).  Anyways, here's a quick fix.

DaveM for your consideration.

Adjust TCP mem order check to new alloc_large_system_hash

Signed-off-by: Andi Kleen <ak@suse.de>

--- linux-2.6.11-work/net/ipv4/tcp.c~	2005-03-02 08:37:51.000000000 +0100
+++ linux-2.6.11-work/net/ipv4/tcp.c	2005-06-11 12:16:22.000000000 +0200
@@ -2337,7 +2337,7 @@
 			(tcp_bhash_size * sizeof(struct tcp_bind_hashbucket));
 			order++)
 		;
-	if (order > 4) {
+	if (order >= 4) {
 		sysctl_local_port_range[0] = 32768;
 		sysctl_local_port_range[1] = 61000;
 		sysctl_tcp_max_tw_buckets = 180000;

       reply	other threads:[~2005-06-11 10:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <75052be7050606070691c302d@mail.gmail.com>
     [not found] ` <75052be705060607106a6c0882@mail.gmail.com>
2005-06-11 10:25   ` Andi Kleen [this message]
2005-06-13 21:24     ` Is kernel 2.6.11 adjust tcp_max_syn_backlog incorrectly? David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m11x79dwcb.fsf@muc.de \
    --to=ak@muc.de \
    --cc=casavan@sgi.com \
    --cc=davem@davemloft.net \
    --cc=gnuwind@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).