* correct include file for restart_syscall
@ 2010-12-13 10:17 Or Gerlitz
2010-12-13 10:51 ` Eric W. Biederman
0 siblings, 1 reply; 2+ messages in thread
From: Or Gerlitz @ 2010-12-13 10:17 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: Roland Dreier, netdev
Hi,
commit 26574401fef6766f6c3ca25b5c13febe662d2a32 "net: Fix ipoib rtnl_lock
sysfs deadlock" modified some flows doing rtnl_lock calls to use rtnl_trylock
/ restart_syscall, etc. It turned out that restart_syscall was included in
ipoib through linux/inet_lro.h which is an include I'd like to remove...
Is including linux/sched.h being the right thing to do? I wasn't sure as
this call is very rare, in network drivers its called only by ipoib and
bonding and it looks like bonding includes it indirectly.
Or.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: correct include file for restart_syscall
2010-12-13 10:17 correct include file for restart_syscall Or Gerlitz
@ 2010-12-13 10:51 ` Eric W. Biederman
0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2010-12-13 10:51 UTC (permalink / raw)
To: Or Gerlitz; +Cc: Roland Dreier, netdev
Or Gerlitz <ogerlitz@voltaire.com> writes:
> Hi,
>
> commit 26574401fef6766f6c3ca25b5c13febe662d2a32 "net: Fix ipoib rtnl_lock
> sysfs deadlock" modified some flows doing rtnl_lock calls to use rtnl_trylock
> / restart_syscall, etc. It turned out that restart_syscall was included in
> ipoib through linux/inet_lro.h which is an include I'd like to remove...
> Is including linux/sched.h being the right thing to do? I wasn't sure as
> this call is very rare, in network drivers its called only by ipoib and
> bonding and it looks like bonding includes it indirectly.
For the definition of restart_syscall yes.
I wish I was clever enough to find a way not to need rtnl_trylock
restart_syscall but unfortunately I don't :(
Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-13 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-13 10:17 correct include file for restart_syscall Or Gerlitz
2010-12-13 10:51 ` Eric W. Biederman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).