From: ebiederm@xmission.com (Eric W. Biederman)
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, socketcan@hartkopp.net, hadi@cyberus.ca,
xemul@sw.ru, tgraf@suug.ch
Subject: Re: [RFC RTNETLINK 00/09]: Netlink link creation API
Date: Wed, 06 Jun 2007 10:13:36 -0600 [thread overview]
Message-ID: <m14plluklr.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <4666D426.2070606@trash.net> (Patrick McHardy's message of "Wed, 06 Jun 2007 17:35:02 +0200")
Patrick McHardy <kaber@trash.net> writes:
>> I still think adding a IFLA_PARTNER or a custom attribute is cleaner
>> in this case. Slight semantic mismatches are the worst design bugs
>> to correct.
>
>
> Indeed, IFLA_PARTNER sounds like a better idea. I just suggested to
> Pavel to create only a single device per newlink operation and binding
> them later, what do you think about that?
I don't think it solves much because we still need a way to report the
partner device.
On the actual using side I think it makes the core of the driver much
more difficult to get right.
Basically if we can't count on having a partner device we have to
add NULL pointer checks and locking to the packet dispatch which
is otherwise unnecessary.
Eric
next prev parent reply other threads:[~2007-06-06 16:15 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 14:12 [RFC RTNETLINK 00/09]: Netlink link creation API Patrick McHardy
2007-06-05 14:12 ` [RFC NETLINK 01/09]: Mark netlink policies const Patrick McHardy
2007-06-05 19:39 ` David Miller
2007-06-05 14:12 ` [RFC RTNETLINK 02/09]: ifindex 0 does not exist Patrick McHardy
2007-06-05 19:40 ` David Miller
2007-06-05 14:12 ` [RFC RTNETLINK 03/09]: Split up rtnl_setlink Patrick McHardy
2007-06-05 19:41 ` David Miller
2007-06-05 14:12 ` [RFC RTNETLINK 04/09]: Link creation API Patrick McHardy
2007-06-05 19:43 ` David Miller
2007-06-05 21:09 ` Patrick McHardy
2007-06-05 22:03 ` Stephen Hemminger
2007-06-05 23:17 ` Patrick McHardy
2007-06-05 23:16 ` Stephen Hemminger
2007-06-06 11:42 ` Patrick McHardy
2007-06-06 16:37 ` Eric W. Biederman
2007-06-06 16:50 ` Patrick McHardy
2007-06-06 18:02 ` Eric W. Biederman
2007-06-05 14:12 ` [RFC DUMMY 05/09]: Use dev->stats Patrick McHardy
2007-06-05 19:44 ` David Miller
2007-06-05 14:13 ` [RFC DUMMY 06/09]: Keep dummy devices on list Patrick McHardy
2007-06-05 19:44 ` David Miller
2007-06-05 14:13 ` [RFC DUMMY 07/09]: Use rtnl_link API Patrick McHardy
2007-06-05 19:46 ` David Miller
2007-06-05 14:13 ` [RFC IFB 08/09]: Keep ifb devices on list Patrick McHardy
2007-06-05 14:13 ` [RFC IFB 09/09]: Use rtnl_link API Patrick McHardy
2007-06-05 14:18 ` [RFC IPROUTE]: iplink: use netlink for link configuration Patrick McHardy
2007-06-05 19:37 ` [RFC RTNETLINK 00/09]: Netlink link creation API David Miller
2007-06-05 21:10 ` Patrick McHardy
2007-06-05 22:00 ` jamal
2007-06-05 22:07 ` Patrick McHardy
2007-06-05 22:29 ` jamal
2007-06-06 0:40 ` Eric W. Biederman
2007-06-06 11:50 ` Patrick McHardy
2007-06-06 15:25 ` Eric W. Biederman
2007-06-06 15:35 ` Patrick McHardy
2007-06-06 15:56 ` Alexey Kuznetsov
2007-06-06 16:32 ` Patrick McHardy
2007-06-06 17:31 ` Eric W. Biederman
2007-06-06 19:14 ` Alexey Kuznetsov
2007-06-07 8:06 ` Eric W. Biederman
2007-06-06 16:13 ` Eric W. Biederman [this message]
2007-06-06 16:25 ` Patrick McHardy
2007-06-06 13:46 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m14plluklr.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=tgraf@suug.ch \
--cc=xemul@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).