From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, containers@lists.osdl.org
Subject: Re: [PATCH 2/2] veth: Configurable nterface MTU
Date: Fri, 27 Feb 2009 04:41:48 -0800 [thread overview]
Message-ID: <m163iwf3w3.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20090227.024916.184944062.davem@davemloft.net> (David Miller's message of "Fri\, 27 Feb 2009 02\:49\:16 -0800 \(PST\)")
David Miller <davem@davemloft.net> writes:
> From: ebiederm@xmission.com (Eric W. Biederman)
> Date: Wed, 25 Feb 2009 21:49:04 -0800
>
>> @@ -249,6 +253,19 @@ static int veth_close(struct net_device *dev)
>> return 0;
>> }
>>
>> +static int is_valid_veth_mtu(int new_mtu)
>> +{
>> + return (new_mtu >= MIN_MTU && new_mtu <= MAX_MTU);
>> +}
>> +
>> +static int veth_change_mtu(struct net_device *dev, int new_mtu)
>> +{
>> + if (is_valid_veth_mtu(new_mtu))
>> + return -EINVAL;
>> + dev->mtu = new_mtu;
>> + return 0;
>> +}
>> +
>
> This validity test seems to be reversed?
Crap. You are correct. I will respin.
Eric
next prev parent reply other threads:[~2009-02-27 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 5:47 [PATCH 1/2] veth: Fix carrier detect Eric W. Biederman
2009-02-26 5:49 ` [PATCH 2/2] veth: Configurable nterface MTU Eric W. Biederman
2009-02-27 10:49 ` David Miller
2009-02-27 12:41 ` Eric W. Biederman [this message]
[not found] ` <m163iwf3w3.fsf-+imSwln9KH6u2/kzUuoCbdi2O/JbrIOy@public.gmane.org>
2009-02-27 13:22 ` David Miller
2009-03-02 4:44 ` [PATCH 1/2] veth: Fix carrier detect David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m163iwf3w3.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).