From: ebiederm@xmission.com (Eric W. Biederman)
To: Patrick McHardy <kaber@trash.net>
Cc: hadi@cyberus.ca, Pavel Emelianov <xemul@sw.ru>,
David Miller <davem@davemloft.net>,
Ben Greear <greearb@candelatech.com>,
Linux Netdev List <netdev@vger.kernel.org>,
Linux Containers <containers@lists.osdl.org>,
Kirill Korotaev <dev@sw.ru>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
devel@openvz.org,
Stephen Hemminger <shemminger@linux-foundation.org>
Subject: Re: [PATCH] Virtual ethernet device (tunnel)
Date: Wed, 02 May 2007 07:40:31 -0600 [thread overview]
Message-ID: <m1647bxs1c.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <46388B19.70300@trash.net> (Patrick McHardy's message of "Wed, 02 May 2007 14:59:05 +0200")
Patrick McHardy <kaber@trash.net> writes:
> jamal wrote:
>> On Wed, 2007-02-05 at 14:34 +0200, Patrick McHardy wrote:
>>
>>
>>>Thats a lot better than using sysfs, but I think it would be
>>>preferrable to use rtnetlink instead of genetlink for network
>>>configuration.
>>
>>
>> or you can just hold rtnl while using genl.
>> I do agree it would be easier to just use rtnetlink ...
>
>
> The rtnl needs to be held in either case, but using a different
> netlink family introduces races in message processing. For example
> a simple:
>
> ip link add dev veth0
> ip route add 10.0.0.0/8 dev veth0
>
> might fail because we have two different input queues and the routing
> message might get processed before the link message.
The consensus from the last thread was pretty much that we need
to implement RTM_NEWLINK and RTM_DELLINK, if it is at all possible.
So that we can get code reuse between different virtual devices.
Although I suspect we will need some per type attribute parsing.
Eric
next prev parent reply other threads:[~2007-05-02 13:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 10:54 [PATCH] Virtual ethernet device (tunnel) Pavel Emelianov
2007-05-02 10:57 ` [PATCH] Make ip utility veth driver aware Pavel Emelianov
2007-05-02 12:07 ` [Devel] [PATCH] Virtual ethernet device (tunnel) Daniel Lezcano
2007-05-02 12:27 ` Pavel Emelianov
2007-05-02 12:34 ` Patrick McHardy
2007-05-02 12:49 ` jamal
2007-05-02 12:59 ` Patrick McHardy
2007-05-02 13:40 ` Eric W. Biederman [this message]
2007-05-02 13:57 ` Patrick McHardy
2007-05-02 16:37 ` Stephen Hemminger
2007-05-02 16:50 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1647bxs1c.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=dev@sw.ru \
--cc=devel@openvz.org \
--cc=greearb@candelatech.com \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=xemul@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).