netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: cndougla@purdue.edu, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: TCP prequeue performance
Date: Thu, 16 Jun 2005 02:23:59 +0200	[thread overview]
Message-ID: <m17jgv9mjk.fsf@muc.de> (raw)
In-Reply-To: <20050615.164115.74747690.davem@davemloft.net> (David S. Miller's message of "Wed, 15 Jun 2005 16:41:15 -0700 (PDT)")

"David S. Miller" <davem@davemloft.net> writes:
>
> Not true, if this check does not pass, tp->ucopy.task is
> never set, therefore prequeue processing is never performed.

Oh well, here goes my nice theory :)
>
> This test must pass the first time, when both tp->ucopy.task
> and user_recv are both NULL, in order for prequeue processing
> to occur at all.
>
> So his change did totally disable prequeue.

Then probably his test was latency bound somehow, but normally
that should not affect system time, just wall time.

I would perhaps compare context switch numbers and netstat -s
output between the different runs and see if anything pops out.

-Andi

      reply	other threads:[~2005-06-16  0:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BED5FA3B.2A0%cndougla@purdue.edu>
2005-06-15 20:51 ` TCP prequeue performance David S. Miller
2005-06-15 23:34 ` Andi Kleen
2005-06-15 23:41   ` David S. Miller
2005-06-16  0:23     ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m17jgv9mjk.fsf@muc.de \
    --to=ak@muc.de \
    --cc=cndougla@purdue.edu \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).