From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory support. Date: Tue, 07 Oct 2008 15:27:12 -0700 Message-ID: References: <48B57058.9000101@bull.net> <48BD47A8.1080909@bull.net> <20080902170148.GA9305@suse.de> <31436f4a0809032233r2c46de8od8a94460ce3b5ed2@mail.gmail.com> <48BF83E1.5040000@bull.net> <20081007164833.GA16056@suse.de> <20081007210902.GB7996@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mark Ryden , Benjamin Thery , David Shwatrz , Greg KH , Andrew Morton , Tejun Heo , Daniel Lezcano , linux-kernel@vger.kernel.org, Al Viro , Linux Containers , netdev@vger.kernel.org To: Greg KH Return-path: Received: from out01.mta.xmission.com ([166.70.13.231]:37388 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755134AbYJGWgE (ORCPT ); Tue, 7 Oct 2008 18:36:04 -0400 In-Reply-To: <20081007210902.GB7996@suse.de> (Greg KH's message of "Tue, 7 Oct 2008 14:09:02 -0700") Sender: netdev-owner@vger.kernel.org List-ID: Greg KH writes: > On Tue, Oct 07, 2008 at 01:31:52PM -0700, Eric W. Biederman wrote: >> Greg KH writes: >> >> > On Tue, Oct 07, 2008 at 06:39:04PM +0200, Mark Ryden wrote: >> >> Hello, >> >> So I wonder: the sysfs tagged directory support patch is in GerKH >> >> tree for more than a month. >> > >> > I dropped it from my tree 2 days ago, see the thread on lkml for why. >> >> Greg why did you drop it? > > Because Al said it was full of problems and for us not to accept it. Yes. Al found problems. Al reviewed sysfs with my patchset on top of it. Al's review found problems in sysfs with my patchset on top of it. If you look at what Al found the majority of those problems exist in sysfs without my patches. Does the following sound like a workable path going forward? - Not merge for 2.6.28 (we are to close to the merge window for everyone's comfort). - Fix the small issues specific to tagged directory support that showed up in Al's review (patches sent). - Keep the patches the entire time in a public tree that merges into linux-next so that people treat this code base seriously. - Resolve the sysfs/vfs lock ordering problem mess that makes locking in sysfs excruciatingly difficult. - Merge other patches to fix Als other issues with sysfs. - Merge to 2.6.29 or wherever we are. Eric