From: ebiederm@xmission.com (Eric W. Biederman)
To: Dhananjay Phadke <dhananjay.phadke@qlogic.com>
Cc: "netdev\@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [patch next 3/4] netxen: fix bonding support
Date: Mon, 26 Oct 2009 22:50:32 -0700 [thread overview]
Message-ID: <m1aazdl713.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <7608421F3572AB4292BB2532AE89D5658B0B6E4F74@AVEXMB1.qlogic.org> (Dhananjay Phadke's message of "Sat\, 24 Oct 2009 10\:29\:50 -0700")
Dhananjay Phadke <dhananjay.phadke@qlogic.com> writes:
>> Yes. That should prevent the null pointer deference. Will it also
>> allow setting the mac address when the NIC is down?
>>
>> Eric
>
> Yes, we do save new address in netdev->dev_addr.
> This is later on programmed in hardware when interface is brought up.
Yep. Thanks. I just tested it and confirmed the crash is no longer there.
Eric
next prev parent reply other threads:[~2009-10-27 5:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 5:05 [patch next 0/4] netxen fixes Dhananjay Phadke
2009-05-06 5:05 ` [patch next 1/4] netxen: fix race in tx ring acccess Dhananjay Phadke
2009-05-06 22:35 ` David Miller
2009-05-06 5:05 ` [patch next 2/4] netxen: fix mac list management Dhananjay Phadke
2009-05-06 22:35 ` David Miller
2009-05-06 5:05 ` [patch next 3/4] netxen: fix bonding support Dhananjay Phadke
2009-05-06 22:35 ` David Miller
2009-10-23 5:57 ` Eric W. Biederman
2009-10-24 1:54 ` Dhananjay Phadke
2009-10-24 2:13 ` Eric W. Biederman
2009-10-24 17:29 ` Dhananjay Phadke
2009-10-27 5:50 ` Eric W. Biederman [this message]
2009-10-27 6:06 ` Dhananjay Phadke
2009-05-06 5:05 ` [patch next 4/4] netxen: disable rss for GbE ports Dhananjay Phadke
2009-05-06 22:37 ` David Miller
2009-05-06 23:06 ` Dhananjay Phadke
2009-05-06 23:31 ` David Miller
2009-05-07 0:08 ` Dhananjay Phadke
2009-05-07 0:28 ` David Miller
2009-05-07 0:31 ` Dhananjay Phadke
2009-05-07 0:40 ` David Miller
2009-05-07 0:42 ` Dhananjay Phadke
2009-05-07 6:15 ` Jesper Dangaard Brouer
2009-05-07 23:44 ` Dhananjay Phadke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1aazdl713.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=dhananjay.phadke@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).