From: ebiederm@xmission.com (Eric W. Biederman)
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Pavel Emelyanov <xemul@openvz.org>,
Linux Netdev List <netdev@vger.kernel.org>,
Linux Containers <containers@lists.osdl.org>,
devel@openvz.org, Daniel Lezcano <dlezcano@fr.ibm.com>
Subject: Re: [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net
Date: Fri, 14 Sep 2007 15:53:21 -0600 [thread overview]
Message-ID: <m1bqc429ta.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070914220714.3a1e87f8@oldman> (Stephen Hemminger's message of "Fri, 14 Sep 2007 22:07:14 +0200")
Stephen Hemminger <shemminger@linux-foundation.org> writes:
> Could we just make it so dev->init is not allowed to fail? Then it
> can be a void function and the nasty unwind code can go?
Unfortunately we need to allocate memory, and perform other operations
that can fail. That's the nature of the problem.
So I think not allowing init to fail would be optimizing for the wrong
the case. Allowing init to fail makes the rest of the code simpler
because we don't have to perform the impossible when the highly
unlikely happens.
The ugly unwind is only about 5 lines of code that never need to
change (except for beautification). So I don't think the cost
is prohibitive.
Eric
next prev parent reply other threads:[~2007-09-14 21:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 7:39 [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net Pavel Emelyanov
2007-09-14 12:49 ` Stephen Hemminger
2007-09-14 14:41 ` Eric W. Biederman
2007-09-14 20:07 ` Stephen Hemminger
2007-09-14 21:53 ` Eric W. Biederman [this message]
2007-09-16 23:49 ` David Miller
2007-09-17 0:06 ` Eric W. Biederman
2007-09-17 0:07 ` David Miller
[not found] ` <46EA3AB4.7060904-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2007-09-14 17:33 ` Eric W. Biederman
-- strict thread matches above, loose matches on Subject: below --
2007-09-17 11:02 Pavel Emelyanov
2007-09-17 13:07 ` Eric W. Biederman
2007-09-17 13:54 ` Pavel Emelyanov
2007-09-18 1:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1bqc429ta.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=containers@lists.osdl.org \
--cc=devel@openvz.org \
--cc=dlezcano@fr.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).