From: ebiederm@xmission.com (Eric W. Biederman)
To: Basil Gor <basil.gor@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Basil Gor <basilgor@gmail.com>
Subject: Re: [PATCH v2] macvlan/macvtap: Fix vlan tagging on user read
Date: Fri, 20 Apr 2012 18:51:51 -0700 [thread overview]
Message-ID: <m1d371zwaw.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <1334964058-3338-1-git-send-email-basilgor@gmail.com> (Basil Gor's message of "Sat, 21 Apr 2012 03:20:58 +0400")
Basil Gor <basil.gor@gmail.com> writes:
> Vlan tag is restored during buffer transmit to a network device (bridge
> port) in bridging code in case of tun/tap driver. In case of macvtap it
> has to be done explicitly. Otherwise vlan_tci is ignored and user always
> gets untagged packets.
>
> Scenario tested:
> kvm guests (that use vlans) migration from bridged network to macvtap
> revealed that packets delivered to guests are always untagged. Dumping
> and comparing sk_buff in case of tap and macvtap driver showed that
> macvtap does not restore vlan_tci.
>
> With current patch applied I was able to get working network, kvm guests
> get correctly tagged packets and can reach each other when macvtap in
> bridge mode (both with no vlans and through vlan interfaces).
>
> Changes from original version:
> vlan header restoring code is moved from macvtap_forward to
> macvtap_receive
I really think this is the wrong fix.
Eric
prev parent reply other threads:[~2012-04-21 1:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 23:20 [PATCH v2] macvlan/macvtap: Fix vlan tagging on user read Basil Gor
2012-04-21 1:51 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1d371zwaw.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=basil.gor@gmail.com \
--cc=basilgor@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).