From: ebiederm@xmission.com (Eric W. Biederman)
To: Julian Anastasov <ja@ssi.bg>
Cc: Simon Horman <horms@verge.net.au>,
David Miller <davem@davemloft.net>,
borntraeger@de.ibm.com, netdev@vger.kernel.org,
wensong@linux-vs.org
Subject: Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy
Date: Wed, 14 Nov 2007 18:10:58 -0700 [thread overview]
Message-ID: <m1d4ucz525.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0711150225280.3658@u.domain.uli> (Julian Anastasov's message of "Thu, 15 Nov 2007 02:38:32 +0200 (EET)")
Julian Anastasov <ja@ssi.bg> writes:
> I assume /proc/sys is still valid place, only sysctl interface
> is scheduled for removal.
Yes. The ascii versions of the sysctls that show up in /proc/sys are
definitely still valid.
> So, as long as these entries are not
> accessible from sysctl it is safe to run without strategy handler but if
> values can be changed then we will need strategy handler to
> properly call update_defense_level() as done in proc_do_defense_mode()
> as proc_handler. There could be side effects if new mode is not applied.
Yes. The current mode of 0644 allows them to be both read and updated
with sys_sysctl. By removing the ctl_name entry those entries become
inaccessible from the /proc/sys interface. Which is some easier then
writing a strategy routine.
Eric
next prev parent reply other threads:[~2007-11-15 1:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 10:29 [PATCH] IPVS: Fix sysctl warnings about missing strategy Christian Borntraeger
2007-11-13 10:45 ` David Miller
2007-11-14 2:12 ` Simon Horman
2007-11-14 15:59 ` Eric W. Biederman
2007-11-15 0:38 ` Julian Anastasov
2007-11-15 1:10 ` Eric W. Biederman [this message]
2007-11-15 1:14 ` Simon Horman
2007-11-15 1:25 ` Eric W. Biederman
2007-11-15 1:33 ` Simon Horman
2007-11-15 22:53 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1d4ucz525.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=borntraeger@de.ibm.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).