From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: pjwaskiewicz@gmail.com, dlezcano@fr.ibm.com,
shemminger@linux-foundation.org, netdev@vger.kernel.org,
containers@lists.osdl.org, benjamin.thery@bull.net
Subject: Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device
Date: Wed, 26 Sep 2007 15:40:25 -0600 [thread overview]
Message-ID: <m1d4w5t8ae.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070925.192406.18290033.davem@davemloft.net> (David Miller's message of "Tue, 25 Sep 2007 19:24:06 -0700 (PDT)")
David Miller <davem@davemloft.net> writes:
> I've put these patches into the just-rebased net-2.6.24 tree.
>
> I made a minor modification to the second patch, the
> out_free_netdev: code in loopback_init() ended like this:
>
> out_free_netdev:
> free_netdev(dev);
> goto out;
> return err;
> };
>
> I got rid of the spurious return statement and the trailing
> semi-colon after the function closing brace.
Thanks. I feel silly for not doing a closer code review of
this variant of the patch and missing this bug.
Eric
prev parent reply other threads:[~2007-09-26 21:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 13:45 [net-2.6.24][patch 0/2] Dynamically allocate the loopback dlezcano
2007-09-17 13:45 ` [net-2.6.24][patch 1/2] Dynamically allocate the loopback device - mindless changes dlezcano
2007-09-17 13:45 ` [net-2.6.24][patch 2/2] Dynamically allocate the loopback device dlezcano
2007-09-17 17:13 ` Stephen Hemminger
2007-09-17 18:52 ` Daniel Lezcano
[not found] ` <46EECCD5.5090601-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2007-09-17 19:12 ` Peter Waskiewicz
2007-09-18 1:53 ` David Miller
2007-09-18 2:44 ` Eric W. Biederman
2007-09-26 2:24 ` David Miller
2007-09-26 21:40 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1d4w5t8ae.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=benjamin.thery@bull.net \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=dlezcano@fr.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=pjwaskiewicz@gmail.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).