From: ebiederm@xmission.com (Eric W. Biederman)
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Jay Vosburgh <fubar@us.ibm.com>,
"Eric W. Biederman" <ebiederm@aristanetworks.com>
Subject: Re: [PATCH 5/6] bond: Implement a basic set of rtnl link ops
Date: Fri, 30 Oct 2009 02:23:31 -0700 [thread overview]
Message-ID: <m1eiols0a4.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4AEAA403.7080204@trash.net> (Patrick McHardy's message of "Fri\, 30 Oct 2009 09\:29\:55 +0100")
Patrick McHardy <kaber@trash.net> writes:
> Eric W. Biederman wrote:
>> +static struct rtnl_link_ops bond_link_ops __read_mostly = {
>> + .kind = "bond",
>> + .setup = bond_setup,
>> + .validate = bond_validate,
>> +};
>
> One more thing - you need to initialize .priv_size here so
> the devices created through rtnl_link have enough private
> room allocated.
Wow and the code works when I test it without that ouch!
As for rtnl_link_register it always succeeds so let's just
remove the return code and call it good.
Eric
next prev parent reply other threads:[~2009-10-30 9:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 0:16 [PATCH 0/6] Bonding simplifications and netns support Eric W. Biederman
2009-10-30 0:18 ` [PATCH 1/6] net: Allow devices to specify a device specific sysfs group Eric W. Biederman
2009-10-30 0:18 ` [PATCH 2/6] bond: Simply bond sysfs group creation Eric W. Biederman
2009-10-30 0:18 ` [PATCH 3/6] bond: Simplify bond_create Eric W. Biederman
2009-10-30 0:18 ` [PATCH 4/6] bond: Simplify bond device destruction Eric W. Biederman
2009-10-30 0:18 ` [PATCH 5/6] bond: Implement a basic set of rtnl link ops Eric W. Biederman
2009-10-30 8:06 ` Patrick McHardy
2009-10-30 8:29 ` Patrick McHardy
2009-10-30 9:23 ` Eric W. Biederman [this message]
2009-10-30 9:33 ` Patrick McHardy
2009-10-30 9:58 ` [PATCH 7/6] bond: Get the rtnl_link_ops support correct Eric W. Biederman
2009-10-30 10:00 ` [PATCH 5/6] bond: Implement a basic set of rtnl link ops Eric W. Biederman
2009-10-30 10:08 ` Patrick McHardy
2009-10-30 0:18 ` [PATCH 6/6] bond: Add support for multiple network namespaces Eric W. Biederman
2009-10-30 6:25 ` [PATCH 0/6] Bonding simplifications and netns support David Miller
2009-10-30 6:38 ` Eric Dumazet
2009-10-30 6:40 ` David Miller
2009-10-30 7:50 ` Eric W. Biederman
2009-10-30 10:39 ` Eric W. Biederman
2009-10-30 19:41 ` David Miller
2009-10-30 21:12 ` Jay Vosburgh
2009-10-30 22:57 ` Eric W. Biederman
2009-10-31 0:10 ` Jay Vosburgh
2009-10-31 1:06 ` Eric W. Biederman
2009-10-31 1:45 ` Jay Vosburgh
2009-10-31 0:27 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1eiols0a4.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=davem@davemloft.net \
--cc=ebiederm@aristanetworks.com \
--cc=fubar@us.ibm.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).