From: ebiederm@xmission.com (Eric W. Biederman)
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Netdev <netdev@vger.kernel.org>, Thomas Graf <tgraf@suug.ch>,
"Eric W. Biederman" <ebiederm@aristanetworks.com>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH] genetlink: make netns aware
Date: Wed, 17 Jun 2009 14:49:30 -0700 [thread overview]
Message-ID: <m1hbyev8d1.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <1245274620.31588.49.camel@johannes.local> (Johannes Berg's message of "Wed\, 17 Jun 2009 23\:37\:00 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2009-06-17 at 14:19 -0700, Eric W. Biederman wrote:
>
>> Nothing at first glance looks wrong.
>
> Will review locking :) Not sure I hold enough locks at the correct
> places here.
grr. At first glance NOTHING looks wrong.
I have a bad habit of skipping the most important word in my sentences
sometimes.
>> Most of these genetlink things are network related so making it
>> network namespace aware makes sense.
>
> Well, some are non-network, and some are network, like nl80211. My goal
> is this patch:
> http://johannes.sipsolutions.net/patches/kernel/all/LATEST/016-cfg80211-netns.patch
>
> It already kinda works, but has bugs like not going back to init_net if
> the ns a wiphy is in exits, and some more like that.
>
>> My impression had been that genetlink was mostly not network related
>> and I would have to solve the other hard problem of how to filter
>> sockets based on other namespaces. I guess that can be delayed for
>> a while longer.
>
> Ah, well, I was thinking that the generic netlink family code would have
> to take care of that.
Probably. As even genetlink has those kinds of users. The kernel
receive path is easy now. Yeah for synchronous processing. It is
which socket do you transmit on that is interesting.
Eric
next prev parent reply other threads:[~2009-06-17 21:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 19:33 [PATCH] genetlink: make netns aware Johannes Berg
2009-06-17 21:19 ` Eric W. Biederman
2009-06-17 21:37 ` Johannes Berg
2009-06-17 21:49 ` Eric W. Biederman [this message]
2009-06-17 21:54 ` Johannes Berg
2009-06-17 21:26 ` Johannes Berg
2009-06-18 2:10 ` Brian Haley
2009-06-18 2:16 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2009-06-18 11:16 Johannes Berg
2009-06-19 1:12 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1hbyev8d1.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=adobriyan@gmail.com \
--cc=ebiederm@aristanetworks.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).