From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: Don't leak 'listeners' in netlink_kernel_create() Date: Sun, 14 Oct 2007 16:30:06 -0600 Message-ID: References: <200710142337.01059.jesper.juhl@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Linux Kernel Mailing List , Alan Cox , Alexey Kuznetsov , David Miller To: Jesper Juhl Return-path: Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:36072 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773AbXJNWb3 (ORCPT ); Sun, 14 Oct 2007 18:31:29 -0400 In-Reply-To: <200710142337.01059.jesper.juhl@gmail.com> (Jesper Juhl's message of "Sun, 14 Oct 2007 23:37:00 +0200") Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Jesper Juhl writes: > From: Jesper Juhl > Subject: Don't leak 'listeners' in netlink_kernel_create() > > The Coverity checker spotted that we'll leak the storage allocated > to 'listeners' in netlink_kernel_create() when the > if (!nl_table[unit].registered) > check is false. > > This patch avoids the leak. > > > Signed-off-by: Jesper Juhl This patch appears trivially correct to me. Acked-by: "Eric W. Biederman" > --- > > af_netlink.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-2.6/net/netlink/af_netlink.c~ 2007-10-14 23:29:50.000000000 +0200 > +++ linux-2.6/net/netlink/af_netlink.c 2007-10-14 23:29:50.000000000 +0200 > @@ -1378,6 +1378,8 @@ netlink_kernel_create(struct net *net, i > nl_table[unit].cb_mutex = cb_mutex; > nl_table[unit].module = module; > nl_table[unit].registered = 1; > + } else { > + kfree(listeners); > } > netlink_table_ungrab(); >