From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 4/4] [IPROUTE2] iproute2: link_veth support bug fixes. Date: Wed, 12 Sep 2007 09:13:02 -0600 Message-ID: References: <46E7F8B1.5090907@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stephen Hemminger , netdev@vger.kernel.org, Patrick McHardy To: Pavel Emelyanov Return-path: Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:55709 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967341AbXILPNf (ORCPT ); Wed, 12 Sep 2007 11:13:35 -0400 In-Reply-To: <46E7F8B1.5090907@openvz.org> (Pavel Emelyanov's message of "Wed, 12 Sep 2007 18:33:21 +0400") Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Pavel Emelyanov writes: > [snip] > >> @@ -25,6 +26,3 @@ clean: >> >> LDLIBS += -ldl >> LDFLAGS += -Wl,-export-dynamic >> - >> -%.so: %.c >> - $(CC) $(CFLAGS) -shared $< -o $@ > > %) How do we get the .so file then? The code was built into iproute2, so we don't need the .so file. That rule does not work on arch/x86_64 so I had to do something and the easiest was to simply compile the code in. Like Patrick did with his recent VLAN support. The usefulness of a .so file seems to be distributing the code outside of /bin/ip. Although I think we currently have some issues with mixed 32bit and 64bit systems because we have "/usr/lib/ip/link_*.so" hard coded. A .so file always seems to override the compiled in version so I don't think we loose any flexibility on that front. Eric