From: ebiederm@xmission.com (Eric W. Biederman)
To: James Morris <jmorris@namei.org>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
David Miller <davem@davemloft.net>,
adobriyan@gmail.com, auke-jan.h.kok@intel.com,
akpm@linux-foundation.org, e1000-devel@lists.sourceforge.net,
netdev@vger.kernel.org, eparis@parisplace.org
Subject: Re: [E1000-devel] networking probs in next-20081203
Date: Thu, 04 Dec 2008 23:49:14 -0800 [thread overview]
Message-ID: <m1k5afqcxx.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <alpine.LRH.1.10.0812051243190.11818@tundra.namei.org> (James Morris's message of "Fri, 5 Dec 2008 13:03:08 +1100 (EST)")
James Morris <jmorris@namei.org> writes:
> On Thu, 4 Dec 2008, Eric W. Biederman wrote:
>
>> Which piece of selinux magic did I miss?
>
> The problem is that SELinux doesn't know anything about the new filesystem
> type, and specifically, to treat it like procfs. There are a couple
> workarounds we can try to prevent this specific problem from cropping up
> again.
The thing is I believe I changed the internal filesystem test to
strncmp(fstype, "proc", 4);
Which should match both proc and proc/net
And likewise I thought I provided the same name by for the magic label
lookup by name.
>> In particular can you tell if this was a code bug or a logic bug?
>
> I wouldn't say it was a bug, more a consequence of necessarily imperfect
> encapsulation of the security code via LSM. It's just something we have to
> keep an eye out for.
Yes. Was the piece I missed in the LSM rules loaded from user space?
Eric
next prev parent reply other threads:[~2008-12-05 7:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 1:18 networking probs in next-20081203 Andrew Morton
2008-12-04 15:14 ` Alexey Dobriyan
2008-12-04 17:41 ` Kok, Auke
2008-12-04 17:52 ` Alexey Dobriyan
2008-12-04 18:11 ` [E1000-devel] " Stephen Smalley
2008-12-04 18:21 ` David Miller
2008-12-04 19:32 ` Stephen Smalley
2008-12-04 20:06 ` Stephen Smalley
2008-12-04 21:00 ` [E1000-devel] " Eric W. Biederman
2008-12-05 2:03 ` James Morris
2008-12-05 7:49 ` Eric W. Biederman [this message]
2008-12-05 14:12 ` Stephen Smalley
2008-12-11 10:41 ` James Morris
2008-12-12 5:24 ` Alexey Dobriyan
2008-12-12 9:26 ` James Morris
2008-12-12 9:29 ` James Morris
2008-12-12 10:51 ` Eric W. Biederman
2008-12-12 21:40 ` [E1000-devel] " James Morris
2008-12-12 21:24 ` Stephen Smalley
2008-12-15 13:28 ` James Morris
2008-12-19 1:04 ` [PATCH 0/3][RFC] Fix security and SELinux handling of proc/* filesystems James Morris
2008-12-19 1:05 ` [PATCH 1/3][RFC] SELinux: correctly detect proc filesystems of the form "proc/foo" James Morris
2008-12-19 12:29 ` David P. Quigley
2008-12-19 1:06 ` [PATCH 2/3][RFC] security: pass mount flags to security_sb_kern_mount() James Morris
2008-12-19 12:52 ` Stephen Smalley
2008-12-19 1:07 ` [PATCH 3/3][RFC] SELinux: don't check permissions for kernel mounts James Morris
2008-12-19 12:52 ` Stephen Smalley
2008-12-19 6:40 ` [PATCH 0/3][RFC] Fix security and SELinux handling of proc/* filesystems David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1k5afqcxx.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=netdev@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).