netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: Linux Containers <containers@lists.osdl.org>,
	<netdev@vger.kernel.org>, Alexey Dobriyan <adobriyan@gmail.com>,
	"Denis V. Lunev" <den@openvz.org>
Subject: [PATCH 0/3] Fix Network namespace shutdown take 2
Date: Fri, 20 Feb 2009 07:47:01 -0800	[thread overview]
Message-ID: <m1ocwxi00a.fsf@fess.ebiederm.org> (raw)


6 months ago when I introduced net_alive I fixed the symptoms
but I failed to properly fix network namespace shutdown.

I realized this when I received a bug report on Tuesday about a
failure in icmp_send caused by packets in the arp_gueue.

It turns out that the net_alive check in netif_receive_skb
is completely unnecessary and just masked the real problem.

If we remove all network devices from a network namespace before we
shutdown network subsystems and protocols then as designed we cannot
have packets in flight causing problems.

It turns out that the root cause of these problems is that the icmp
code was calling register_pernet_device instead of
register_pernet_subsys and so it's cleanup was happening much too
early.

The following patchset which should work against both 2.6.29-rcX
and net-next fixes the registration problems and removes the
unncessary net_alive check, making the code simpler and hopefully
more comprehensible.

Eric

             reply	other threads:[~2009-02-20 15:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20 15:47 Eric W. Biederman [this message]
2009-02-20 15:52 ` [PATCH 1/3] netns: Fix icmp shutdown Eric W. Biederman
2009-02-20 15:53   ` [PATCH 2/3] tcp: Like icmp use register_pernet_subsys Eric W. Biederman
     [not found]     ` <m163j5hzow.fsf_-_-+imSwln9KH6u2/kzUuoCbdi2O/JbrIOy@public.gmane.org>
2009-02-20 15:57       ` Denis V. Lunev
2009-02-22  8:10         ` David Miller
2009-02-20 16:02     ` [PATCH 3/3] netns: Remove net_alive Eric W. Biederman
2009-02-22  8:11       ` David Miller
     [not found]   ` <m1bpsxhzqz.fsf-+imSwln9KH6u2/kzUuoCbdi2O/JbrIOy@public.gmane.org>
2009-02-20 15:57     ` [PATCH 1/3] netns: Fix icmp shutdown Denis V. Lunev
2009-02-22  8:09       ` David Miller
2009-02-25 12:43 ` [PATCH 0/3] Fix Network namespace shutdown take 2 Daniel Lezcano
2009-03-03  9:07   ` David Miller
2009-03-05 12:35     ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ocwxi00a.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=adobriyan@gmail.com \
    --cc=containers@lists.osdl.org \
    --cc=davem@davemloft.net \
    --cc=den@openvz.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).