From: Andi Kleen <ak@muc.de>
To: Christoph Lameter <christoph@graphe.net>
Cc: netdev@oss.sgi.com, akpm@osdl.org
Subject: Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000
Date: Wed, 18 May 2005 04:05:25 +0200 [thread overview]
Message-ID: <m1sm0l5lwa.fsf@muc.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0505171854490.20408@graphe.net> (Christoph Lameter's message of "Tue, 17 May 2005 18:56:06 -0700 (PDT)")
Christoph Lameter <christoph@graphe.net> writes:
> @@ -513,6 +513,7 @@ e1000_probe(struct pci_dev *pdev,
> netdev->mem_start = mmio_start;
> netdev->mem_end = mmio_start + mmio_len;
> netdev->base_addr = adapter->hw.io_base;
> + netdev->node = pcibus_to_node(pdev->bus);
I think it would be better to define a common helper (pdev_kmalloc ?)
for this that just takes the pdev and that can be defined to a nop for
!CONFIG_NUMA Kernels. This would avoid the bloat of the ->node
argument on non numa kernels and is a cleaner interface
too. pcibus_to_node() is just an array lookup and should be cheap
enough to redo.
-Andi
next prev parent reply other threads:[~2005-05-18 2:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 1:56 [PATCH] NUMA aware allocation of transmit and receive buffers for e1000 Christoph Lameter
2005-05-18 2:03 ` Andrew Morton
2005-05-18 2:52 ` Christoph Lameter
2005-05-18 2:57 ` David S. Miller
2005-05-18 4:27 ` Christoph Lameter
2005-05-18 4:58 ` Andrew Morton
2005-05-18 15:55 ` Ganesh Venkatesan
2005-05-18 20:42 ` Andrew Morton
2005-05-27 21:52 ` [PATCH] e1000: NUMA aware allocation of descriptors V2 Christoph Lameter
2005-05-27 23:25 ` Andrew Morton
2005-05-18 13:19 ` [PATCH] NUMA aware allocation of transmit and receive buffers for e1000 Andi Kleen
2005-05-18 2:05 ` Andi Kleen [this message]
2005-05-18 7:49 ` Eric Dumazet
2005-05-18 13:28 ` Andi Kleen
2005-05-27 21:15 ` Christoph Lameter
2005-05-30 9:41 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1sm0l5lwa.fsf@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=christoph@graphe.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).