From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: Robert.Olsson@data.slu.se, netdev@vger.kernel.org,
robert.olsson@its.uu.se
Subject: Re: [PATCH] net: Fix the fib trie iterator to work with a single entry routing tables
Date: Wed, 24 Jan 2007 19:11:51 -0700 [thread overview]
Message-ID: <m1tzyfzwgo.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070124.144254.78492493.davem@davemloft.net> (David Miller's message of "Wed, 24 Jan 2007 14:42:54 -0800 (PST)")
David Miller <davem@davemloft.net> writes:
> From: Robert Olsson <Robert.Olsson@data.slu.se>
> Date: Wed, 24 Jan 2007 22:43:30 +0100
>
>> Yes the case when the trie is just a single leaf got wrong with the
>> iterator and your patchs cures it. I think we have a similar problem
>> with /proc/net/fib_trie
>
> I'm happy to review a fix for that :-)
>
>> Signed-off-by: Robert Olsson <robert.olsson@its.uu.se>
>
> Patch applied, thanks everyone.
Same iterator function so this fixes that as well.
Eric
next prev parent reply other threads:[~2007-01-25 2:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-24 19:56 [PATCH] net: Fix the fib trie iterator to work with a single entry routing tables Eric W. Biederman
2007-01-24 21:43 ` Robert Olsson
2007-01-24 22:42 ` David Miller
2007-01-25 2:11 ` Eric W. Biederman [this message]
2007-01-26 12:56 ` Robert Olsson
2007-01-26 15:42 ` Eric W. Biederman
2007-01-27 3:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1tzyfzwgo.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=robert.olsson@its.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).