netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: <netdev@vger.kernel.org>, Pavel Emelyanov <xemul@openvz.org>,
	Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] [IPROUTE2] Add support for moving links between network namespaces
Date: Wed, 12 Sep 2007 08:06:08 -0600	[thread overview]
Message-ID: <m1veag9dwv.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070912153909.6b80448f@oldman> (Stephen Hemminger's message of "Wed, 12 Sep 2007 15:39:09 +0200")

Stephen Hemminger <shemminger@linux-foundation.org> writes:

> On Wed, 12 Sep 2007 07:05:42 -0600
> ebiederm@xmission.com (Eric W. Biederman) wrote:
>
>> 
>> This adds support for setting the IFLA_NET_NS_PID attribute
>> on links allowing them to be moved between network namespaces.
>> 
>> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
>> ---
>>  include/linux/if_link.h |    1 +
>>  ip/iplink.c             |    9 +++++++++
>>  2 files changed, 10 insertions(+), 0 deletions(-)
>
> Please don't mix header file updates with command changes.
> As a first step, I always install standard kernel santized headers.

Sorry I didn't know.  Those changes are now in net-2.6.24
so installing sanitized headers should not change anything.

In please feel free to drop the if_link.h part, and if you want
I can resend that patch with those few lines deleted.

Eric

  reply	other threads:[~2007-09-12 14:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12 12:55 [PATCH 1/4] [IPROUTE2] Revert "Make ip utility veth driver aware" Eric W. Biederman
2007-09-12 12:55 ` Pavel Emelyanov
2007-09-12 13:09   ` Eric W. Biederman
2007-09-12 13:48     ` Eric W. Biederman
2007-09-12 12:58 ` [PATCH 2/6] [IPROUTE2] Introduce iplink_parse() routine Eric W. Biederman
2007-09-12 12:59   ` [PATCH 3/4] [IPROUTE2] Module for ip utility to support veth device Eric W. Biederman
2007-09-12 13:01     ` [PATCH 4/4] [IPROUTE2] iproute2: link_veth support bug fixes Eric W. Biederman
2007-09-12 13:03       ` [PATCH] [IPROUTE2] Basic documentation for dynamic link creation/destruction Eric W. Biederman
2007-09-12 13:05         ` [PATCH] [IPROUTE2] Add support for moving links between network namespaces Eric W. Biederman
2007-09-12 13:39           ` Stephen Hemminger
2007-09-12 14:06             ` Eric W. Biederman [this message]
2007-09-12 14:13               ` Stephen Hemminger
2007-09-12 14:33       ` [PATCH 4/4] [IPROUTE2] iproute2: link_veth support bug fixes Pavel Emelyanov
2007-09-12 15:13         ` Eric W. Biederman
2007-09-13 10:30           ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1veag9dwv.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).