From: ebiederm@xmission.com (Eric W. Biederman)
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: akpm@linuxfoundation.org, Chris Wright <chrisw@sous-sol.org>,
stephen.hemminger@vyatta.com, adobriyan@gmail.com,
morgan@kernel.org, xemul@openvz.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] sysctl: allow override of /proc/sys/net with CAP_NET_ADMIN
Date: Fri, 30 May 2008 18:59:26 -0700 [thread overview]
Message-ID: <m1wslbcjy9.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <20080530161857.25e3fbc5@extreme> (Stephen Hemminger's message of "Fri, 30 May 2008 16:18:57 -0700")
Stephen Hemminger <shemminger@vyatta.com> writes:
> Extend the permission check for networking sysctl's to allow
> modification when current process has CAP_NET_ADMIN capability and
> is not root. This version uses the until now unused permissions hook
> to override the mode value for /proc/sys/net if accessed by a user
> with capabilities.
Looks reasonable but a little incomplete.
Could you modify register_net_sysctl_table to set this attribute?
Or alternatively all of the tables registered with register_net_sysctl.
Otherwise I this will not affect all of the sysctls under
/proc/sys/net. Which appears to be your intent.
> Found while working with Quagga. It is impossible to turn forwarding
> on/off through the command interface because Quagga uses secure coding
> practice of dropping privledges during initialization and only raising
> via capabilities when necessary. Since the dameon has reset real/effective
> uid after initialization, all attempts to access /proc/sys/net variables
> will fail.
Eric
next parent reply other threads:[~2008-05-31 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200805292349.m4TNneua029348@imap1.linux-foundation.org>
[not found] ` <20080530161857.25e3fbc5@extreme>
2008-05-31 1:59 ` Eric W. Biederman [this message]
2008-05-31 2:10 ` [PATCH] sysctl: allow override of /proc/sys/net with CAP_NET_ADMIN Stephen Hemminger
2008-05-31 2:29 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1wslbcjy9.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linuxfoundation.org \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morgan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stephen.hemminger@vyatta.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).