From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, Amit Kumar Salecha <amit.salecha@qlogic.com>
Subject: [PATCH] netxen: The driver doesn't work on NX_P3_B1 so cause probe to fail.
Date: Thu, 18 Mar 2010 01:24:39 -0700 [thread overview]
Message-ID: <m1y6hqdol4.fsf@fess.ebiederm.org> (raw)
I haven't been able to get link up on a NX_P3_B1 since 2.6.31. The
driver complains about a firmware hang instead. When I asked I was
told rev 0x41 was a preproduction rev. So disable support in the
driver so no one is surprised the code doesn't work.
Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
---
drivers/net/netxen/netxen_nic_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index 08780ef..9a7a0f3 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -1246,8 +1246,8 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
int pci_func_id = PCI_FUNC(pdev->devfn);
uint8_t revision_id;
- if (pdev->revision >= NX_P3_A0 && pdev->revision < NX_P3_B1) {
- pr_warning("%s: chip revisions between 0x%x-0x%x"
+ if (pdev->revision >= NX_P3_A0 && pdev->revision <= NX_P3_B1) {
+ pr_warning("%s: chip revisions between 0x%x-0x%x "
"will not be enabled.\n",
module_name(THIS_MODULE), NX_P3_A0, NX_P3_B1);
return -ENODEV;
--
1.6.6.1
next reply other threads:[~2010-03-18 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 8:24 Eric W. Biederman [this message]
2010-03-18 8:55 ` [PATCH] netxen: The driver doesn't work on NX_P3_B1 so cause probe to fail Amit Salecha
2010-03-18 9:43 ` Eric W. Biederman
2010-03-19 5:21 ` David Miller
2010-03-19 5:36 ` Amit Salecha
2010-03-19 12:03 ` Amit Salecha
2010-03-22 6:35 ` Amit Salecha
2010-03-23 3:32 ` David Miller
2010-03-18 9:28 ` Amit Salecha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1y6hqdol4.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=amit.salecha@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox