From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch,
horms@kernel.org, ast@fiberby.net
Subject: Re: [PATCH net-next v2 2/2] tools: ynl: rework the string representation of NlError
Date: Tue, 28 Oct 2025 10:51:20 +0000 [thread overview]
Message-ID: <m21pmnqoyf.fsf@gmail.com> (raw)
In-Reply-To: <20251027192958.2058340-2-kuba@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes:
> In early days of YNL development dumping the NlMsg on errors
> was quite useful, as the library itself could have been buggy.
> These days increasingly the NlMsg is just taking up screen space
> and means nothing to a typical user. Try to format the errors
> more in line with how YNL C formats its errors strings.
>
> Before:
> $ ynl --family ethtool --do channels-set --json '{}'
> Netlink error: Invalid argument
> nl_len = 44 (28) nl_flags = 0x300 nl_type = 2
> error: -22
> extack: {'miss-type': 'header'}
>
> $ ynl --family ethtool --do channels-set --json '{..., "tx-count": 999}'
> Netlink error: Invalid argument
> nl_len = 88 (72) nl_flags = 0x300 nl_type = 2
> error: -22
> extack: {'msg': 'requested channel count exceeds maximum', 'bad-attr': '.tx-count'}
>
> After:
> $ ynl --family ethtool --do channels-set --json '{}'
> Netlink error: Invalid argument {'miss-type': 'header'}
>
> $ ynl --family ethtool --do channels-set --json '{..., "tx-count": 999}'
> Netlink error: requested channel count exceeds maximum: Invalid argument {'bad-attr': '.tx-count'}
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2025-10-28 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 19:29 [PATCH net-next v2 1/2] tools: ynl: fix indent issues in the main Python lib Jakub Kicinski
2025-10-27 19:29 ` [PATCH net-next v2 2/2] tools: ynl: rework the string representation of NlError Jakub Kicinski
2025-10-28 10:51 ` Donald Hunter [this message]
2025-10-28 13:58 ` Andrew Lunn
2025-10-28 23:34 ` Jakub Kicinski
2025-10-28 10:50 ` [PATCH net-next v2 1/2] tools: ynl: fix indent issues in the main Python lib Donald Hunter
2025-10-28 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21pmnqoyf.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).