Re: [RFC ipsec-next 8/8] iptfs: impl: add new iptfs xfrm mode impl

[Christian Hopps <chopps@labn.net>]

[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]


Simon Horman <horms@kernel.org> writes:

> On Fri, Nov 10, 2023 at 06:37:19AM -0500, Christian Hopps wrote:
>> From: Christian Hopps <chopps@labn.net>
>>
>> Add a new xfrm mode implementing AggFrag/IP-TFS from RFC9347.
>>
>> This utilizes the new xfrm_mode_cbs to implement demand-driven IP-TFS
>> functionality. This functionality can be used to increase bandwidth
>> utilization through small packet aggregation, as well as help solve PMTU
>> issues through it's efficient use of fragmentation.
>>
>> Link: https://www.rfc-editor.org/rfc/rfc9347.txt
>>
>> Signed-off-by: Christian Hopps <chopps@labn.net>
>
> ...
>
>> diff --git a/net/xfrm/xfrm_iptfs.c b/net/xfrm/xfrm_iptfs.c
>
> ...
>
>> +/* ================= */
>> +/* Utility Functions */
>> +/* ================= */
>> +
>> +static inline u32 __trace_ip_proto(struct iphdr *iph)
>> +{
>> +	if (iph->version == 4)
>> +		return iph->protocol;
>> +	return ((struct ipv6hdr *)iph)->nexthdr;
>> +}
>
> Hi Christian,
>
> please don't use inline in .c files unless there is a demonstrable reason
> to do so. Rather, please leave inlining up to the compiler.

Removed all cases.

Thanks,
Chris.

>
> ...


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 858 bytes --]