From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
donald.hunter@redhat.com
Subject: Re: [PATCH net-next v2 5/6] tools: ynl: Add fixed-header support to ynl
Date: Wed, 22 Mar 2023 11:54:56 +0000 [thread overview]
Message-ID: <m2355xj90v.fsf@gmail.com> (raw)
In-Reply-To: <20230321223440.2bc23eba@kernel.org> (Jakub Kicinski's message of "Tue, 21 Mar 2023 22:34:40 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> On Sun, 19 Mar 2023 19:38:02 +0000 Donald Hunter wrote:
>>
>> def _dictify_ops_directional(self):
>> + default_fixed_header = self.yaml['operations'].get('fixed-header')
>> req_val = rsp_val = 1
>> for elem in self.yaml['operations']['list']:
>> if 'notify' in elem:
>> @@ -426,7 +430,7 @@ class SpecFamily(SpecElement):
>> else:
>> raise Exception("Can't parse directional ops")
>>
>> - op = self.new_operation(elem, req_val, rsp_val)
>> + op = self.new_operation(elem, req_val, rsp_val, default_fixed_header)
>
> Can we record the "family-default" fixed header in the family and read
> from there rather than passing the arg around?
Yes, will do.
> Also - doc - to be clear - by documentation I mean in the right places
> under Documentation/user-api/netlink/
Ack.
next prev parent reply other threads:[~2023-03-22 11:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 19:37 [PATCH net-next v2 0/6] ynl: add support for user headers and struct attrs Donald Hunter
2023-03-19 19:37 ` [PATCH net-next v2 1/6] tools: ynl: Fix genlmsg header encoding formats Donald Hunter
2023-03-19 19:37 ` [PATCH net-next v2 2/6] tools: ynl: Add struct parsing to nlspec Donald Hunter
2023-03-22 5:22 ` Jakub Kicinski
2023-03-22 11:38 ` Donald Hunter
2023-03-22 18:25 ` Jakub Kicinski
2023-03-19 19:38 ` [PATCH net-next v2 3/6] tools: ynl: Add array-nest attr decoding to ynl Donald Hunter
2023-03-22 5:18 ` Jakub Kicinski
2023-03-22 11:27 ` Donald Hunter
2023-03-22 18:27 ` Jakub Kicinski
2023-03-19 19:38 ` [PATCH net-next v2 4/6] tools: ynl: Add struct " Donald Hunter
2023-03-22 5:30 ` Jakub Kicinski
2023-03-22 11:48 ` Donald Hunter
2023-03-22 18:37 ` Jakub Kicinski
2023-03-22 22:06 ` Donald Hunter
2023-03-19 19:38 ` [PATCH net-next v2 5/6] tools: ynl: Add fixed-header support " Donald Hunter
2023-03-22 5:34 ` Jakub Kicinski
2023-03-22 11:54 ` Donald Hunter [this message]
2023-03-19 19:38 ` [PATCH net-next v2 6/6] netlink: specs: add partial specification for openvswitch Donald Hunter
2023-03-23 3:50 ` [PATCH net-next v2 0/6] ynl: add support for user headers and struct attrs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2355xj90v.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).