From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch,
horms@kernel.org, johannes@sipsolutions.net,
razor@blackwall.org
Subject: Re: [PATCH net-next v2 3/4] netlink: specs: remove implicit structs for SNMP counters
Date: Wed, 07 May 2025 11:54:07 +0100 [thread overview]
Message-ID: <m24ixwofn4.fsf@gmail.com> (raw)
In-Reply-To: <20250506194101.696272-4-kuba@kernel.org> (Jakub Kicinski's message of "Tue, 6 May 2025 12:40:59 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> uAPI doesn't define structs for the SNMP counters, just enums to index
> them as arrays. Switch to the same representation in the spec. C codegen
> will soon need all the struct types to actually exist.
>
> Note that the existing definition was broken, anyway, as the first
> member should be the number of counters reported.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2025-05-07 11:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 19:40 [PATCH net-next v2 0/4] netlink: specs: remove phantom structs Jakub Kicinski
2025-05-06 19:40 ` [PATCH net-next v2 1/4] netlink: specs: nl80211: drop structs which are not uAPI Jakub Kicinski
2025-05-06 19:40 ` [PATCH net-next v2 2/4] netlink: specs: ovs: correct struct names Jakub Kicinski
2025-05-06 19:40 ` [PATCH net-next v2 3/4] netlink: specs: remove implicit structs for SNMP counters Jakub Kicinski
2025-05-07 10:54 ` Donald Hunter [this message]
2025-05-06 19:41 ` [PATCH net-next v2 4/4] netlink: specs: rt-link: remove implicit structs from devconf Jakub Kicinski
2025-05-07 11:15 ` Donald Hunter
2025-05-08 1:40 ` [PATCH net-next v2 0/4] netlink: specs: remove phantom structs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24ixwofn4.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).