From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch,
horms@kernel.org, yuyanghuang@google.com,
jacob.e.keller@intel.com
Subject: Re: [PATCH net v3 4/4] netlink: specs: rt_route: pull the ifa- prefix out of the names
Date: Thu, 03 Apr 2025 09:37:47 +0100 [thread overview]
Message-ID: <m24iz5hc84.fsf@gmail.com> (raw)
In-Reply-To: <20250403013706.2828322-5-kuba@kernel.org> (Jakub Kicinski's message of "Wed, 2 Apr 2025 18:37:06 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> YAML specs don't normally include the C prefix name in the name
> of the YAML attr. Remove the ifa- prefix from all attributes
> in route-attrs and metrics and specify name-prefix instead.
>
> This is a bit risky, hopefully there aren't many users out there.
>
> Fixes: 023289b4f582 ("doc/netlink: Add spec for rt route messages")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2025-04-03 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 1:37 [PATCH net v3 0/4] netlink: specs: rt_addr: fix problems revealed by C codegen Jakub Kicinski
2025-04-03 1:37 ` [PATCH net v3 1/4] netlink: specs: rt_addr: fix the spec format / schema failures Jakub Kicinski
2025-04-03 1:37 ` [PATCH net v3 2/4] netlink: specs: rt_addr: fix get multi command name Jakub Kicinski
2025-04-03 8:34 ` Donald Hunter
2025-04-03 1:37 ` [PATCH net v3 3/4] netlink: specs: rt_addr: pull the ifa- prefix out of the names Jakub Kicinski
2025-04-03 8:36 ` Donald Hunter
2025-04-03 1:37 ` [PATCH net v3 4/4] netlink: specs: rt_route: " Jakub Kicinski
2025-04-03 8:37 ` Donald Hunter [this message]
2025-04-04 15:10 ` [PATCH net v3 0/4] netlink: specs: rt_addr: fix problems revealed by C codegen patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24iz5hc84.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yuyanghuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).