From: Donald Hunter <donald.hunter@gmail.com>
To: Alessandro Marcolini <alessandromarcolini99@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, sdf@google.com, chuck.lever@oracle.com,
lorenzo@kernel.org, jacob.e.keller@intel.com, jiri@resnulli.us,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] tools: ynl: correct typo and docstring
Date: Tue, 23 Jan 2024 16:28:38 +0000 [thread overview]
Message-ID: <m24jf4ypxl.fsf@gmail.com> (raw)
In-Reply-To: <800f2681d56b5195c8b22173a3b83bbac021af92.1705950652.git.alessandromarcolini99@gmail.com> (Alessandro Marcolini's message of "Mon, 22 Jan 2024 20:19:39 +0100")
Alessandro Marcolini <alessandromarcolini99@gmail.com> writes:
> Correct typo in SpecAttr docstring. Changed SpecSubMessageFormat
> docstring.
These docstring updates lgtm.
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
> Signed-off-by: Alessandro Marcolini <alessandromarcolini99@gmail.com>
> ---
> tools/net/ynl/lib/nlspec.py | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/net/ynl/lib/nlspec.py b/tools/net/ynl/lib/nlspec.py
> index 44f13e383e8a..f8feae363970 100644
> --- a/tools/net/ynl/lib/nlspec.py
> +++ b/tools/net/ynl/lib/nlspec.py
> @@ -144,7 +144,7 @@ class SpecEnumSet(SpecElement):
>
>
> class SpecAttr(SpecElement):
> - """ Single Netlink atttribute type
> + """ Single Netlink attribute type
>
> Represents a single attribute type within an attr space.
>
> @@ -306,10 +306,9 @@ class SpecSubMessage(SpecElement):
>
>
> class SpecSubMessageFormat(SpecElement):
> - """ Netlink sub-message definition
> + """ Netlink sub-message format definition
>
> - Represents a set of sub-message formats for polymorphic nlattrs
> - that contain type-specific sub messages.
> + Represents a single format for a sub-message.
>
> Attributes:
> value attribute value to match against type selector
next prev parent reply other threads:[~2024-01-23 16:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 19:19 [PATCH net-next 0/3] tools: ynl: Add sub-message and multi-attr encoding support Alessandro Marcolini
2024-01-22 19:19 ` [PATCH net-next 1/3] tools: ynl: correct typo and docstring Alessandro Marcolini
2024-01-23 16:28 ` Donald Hunter [this message]
2024-01-22 19:19 ` [PATCH net-next 2/3] doc: netlink: specs: tc: add multi-attr to tc-taprio-sched-entry Alessandro Marcolini
2024-01-23 16:35 ` Donald Hunter
2024-01-22 19:19 ` [PATCH net-next 3/3] tools: ynl: add encoding support for 'sub-message' to ynl Alessandro Marcolini
2024-01-22 19:46 ` Breno Leitao
2024-01-22 20:31 ` Alessandro Marcolini
2024-01-23 16:44 ` Donald Hunter
2024-01-24 9:12 ` Alessandro Marcolini
2024-01-24 9:45 ` Donald Hunter
2024-01-22 21:43 ` [PATCH net-next 0/3] tools: ynl: Add sub-message and multi-attr encoding support Donald Hunter
2024-01-23 0:40 ` Alessandro Marcolini
-- strict thread matches above, loose matches on Subject: below --
2024-01-24 16:34 [PATCH net-next 0/3] Add support for encoding multi-attr to ynl Alessandro Marcolini
2024-01-24 16:34 ` [PATCH net-next 1/3] tools: ynl: correct typo and docstring Alessandro Marcolini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24jf4ypxl.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=alessandromarcolini99@gmail.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).