iwlwifi: remove EXPORT_SYMBOL for static symbol

iwlwifi: remove EXPORT_SYMBOL for static symbol

[Andreas Schwab]

It does not make sense to apply EXPORT_SYMBOL to a static symbol.  Fixes
this build error:

drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict

Signed-off-by: Andreas Schwab <schwab-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
---
This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
misattributed as a compiler bug.
---
 drivers/net/wireless/iwlwifi/iwl3945-base.c |    1 -
 1 file changed, 1 deletion(-)

--- linux-2.6.30-rc4.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c	2009-04-30 08:59:41.000000000 +0200
+++ linux-2.6.30-rc4/drivers/net/wireless/iwlwifi/iwl3945-base.c	2009-04-30 09:34:14.000000000 +0200
@@ -1745,7 +1745,6 @@ static void iwl3945_rx_queue_free(struct
 	rxq->bd = NULL;
 	rxq->rb_stts  = NULL;
 }
-EXPORT_SYMBOL(iwl3945_rx_queue_free);
 
 
 /* Convert linear signal-to-noise ratio into dB */

-- 
Andreas Schwab, schwab-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: iwlwifi: remove EXPORT_SYMBOL for static symbol

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

On Thu, 2009-04-30 at 09:58 +0200, Andreas Schwab wrote:
> It does not make sense to apply EXPORT_SYMBOL to a static symbol.  Fixes
> this build error:
> 
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:
> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> 
> Signed-off-by: Andreas Schwab <schwab-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
> ---
> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
> misattributed as a compiler bug.

At least in my tree the function isn't static...(yet I still got the
compiler error)?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: iwlwifi: remove EXPORT_SYMBOL for static symbol

[reinette chatre]

On Thu, 2009-04-30 at 00:58 -0700, Andreas Schwab wrote:
> It does not make sense to apply EXPORT_SYMBOL to a static symbol.  Fixes
> this build error:
> 
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> 
> Signed-off-by: Andreas Schwab <schwab-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
> ---
> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was

>From which repo is this commit id? 

> misattributed as a compiler bug.
> ---
>  drivers/net/wireless/iwlwifi/iwl3945-base.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- linux-2.6.30-rc4.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c	2009-04-30 08:59:41.000000000 +0200
> +++ linux-2.6.30-rc4/drivers/net/wireless/iwlwifi/iwl3945-base.c	2009-04-30 09:34:14.000000000 +0200
> @@ -1745,7 +1745,6 @@ static void iwl3945_rx_queue_free(struct
>  	rxq->bd = NULL;
>  	rxq->rb_stts  = NULL;
>  }
> -EXPORT_SYMBOL(iwl3945_rx_queue_free);
>  
> 
>  /* Convert linear signal-to-noise ratio into dB */
> 

Acked-by: Reinette Chatre <reinette.chatre-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Thank you

Reinette


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html