netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Samir Bellabes <sbellabes@mandriva.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Daniel Drake <dsd@gentoo.org>, netdev@vger.kernel.org
Subject: Re: [2.6.18 backport] RTL8168 ethernet support in r8169
Date: Fri, 29 Sep 2006 04:46:48 +0200	[thread overview]
Message-ID: <m264f7jso7.fsf@cerbere.dyndns.info> (raw)
In-Reply-To: <20060926191458.GB15039@electric-eye.fr.zoreil.com> (Francois Romieu's message of "Tue, 26 Sep 2006 21:14:58 +0200")

Francois Romieu <romieu@fr.zoreil.com> writes:

> Daniel Drake <dsd@gentoo.org> :
> [...]
>  static struct pci_device_id rtl8169_pci_tbl[] = {
> -	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8169), },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8129), },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK,	0x4300), },
> -	{ PCI_DEVICE(0x16ec,			0x0116), },
> -	{ PCI_VENDOR_ID_LINKSYS,		0x1032, PCI_ANY_ID, 0x0024, },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8129), 0, 0, RTL_CFG_0 },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8136), 0, 0, RTL_CFG_1 },
>
> Should be RTL_CFG_2 (but there are still issues with the link management).
>
> +	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8167), 0, 0, RTL_CFG_1 },
>                                                                ^^^^^^^^^
> Should be RTL_CFG_1.

You mean should be RTL_CFG_0 ?

> Is there any chance that you can push a different patch for your releases ?
>
> There are no pending changes outside of the git vanilla tree. As an option,
> you can use the patch below too:
> http://www.fr.zoreil.com/people/francois/misc/20060920-2.6.18-r8169-test.patch

I have backported this pointed patch to 2.6.17. [1]
So far, it have been tested successfully with this devices:
RTL-8169
RTL-8169SC
RTL-8168

[1] http://cvs.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/kernel-2.6/current/PATCHES/patches/DN85_r8169_others.patch?root=svn&view=log

regards,

-- 
Samir Bellabes
Mandriva

  parent reply	other threads:[~2006-09-29  2:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-26 18:34 [2.6.18 backport] RTL8168 ethernet support in r8169 Daniel Drake
2006-09-26 19:14 ` Francois Romieu
2006-09-26 22:52   ` Daniel Drake
2006-09-29  2:46   ` Samir Bellabes [this message]
2006-09-29  7:00     ` Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m264f7jso7.fsf@cerbere.dyndns.info \
    --to=sbellabes@mandriva.com \
    --cc=dsd@gentoo.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).